(components) fix/patch: various updates and improvements#467
(components) fix/patch: various updates and improvements#467andrewrubin wants to merge 6 commits into
Conversation
… object, due to NextJS turbopack issue with :export
…ttings per latest WTC default grid
andrewrubin
requested review from
NicholasLancey,
consolecmnd,
liamegan,
marlonmarcello,
meteoratlas,
pravton and
saugatmalla
🦋 Changeset detectedLatest commit: a2837a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| list-style: none; | ||
| margin-inline: auto; | ||
| padding-inline: calc(var(--wtc-gutter-width, 24px) * 0.5); | ||
| padding-inline: calc(var(--wtc-grid-margin-width) - var(--wtc-gutter-width) * 0.5); |
There was a problem hiding this comment.
Hey @andrewrubin , while you are at it, what do you think about updating the grid to use gap instead so we don't need to do any of these shenanigans and nesting is much easier?
There was a problem hiding this comment.
I'll think about this some today @marlonmarcello, good idea! If I can't get to it by the end of the week though, let's do it in another PR. At the moment this PR addresses fundamental issues in our workflow so I think it's slightly more urgent.
| inset-inline: 100%; | ||
| margin-inline: auto; | ||
| padding-inline: calc(var(--wtc-gutter-width, 24px)); | ||
| padding-inline: calc(var(--wtc-grid-margin-width)); |
There was a problem hiding this comment.
nitpick: we don't need the calc() here.
| padding-inline: calc(var(--wtc-grid-margin-width)); | |
| padding-inline: var(--wtc-grid-margin-width); |
There was a problem hiding this comment.
Applied your suggestion, TY
…r/wrapper.module.scss Co-authored-by: Clinton <80900245+pravton@users.noreply.github.com> Signed-off-by: Andrew Rubin <30575213+andrewrubin@users.noreply.github.com>
3 participants
Description
This PR bumps the
wethegit-componentspackage to version 4.0.0. It includes the following fixes and updates:useBreakpoints, due to Next JS and Turbopack no longer supporting the:exportfeature. Instead, this value is hard-coded in theuse-breakpoints.tsfile now.grid-layoutsystem to use the latest standards created by We the Collective's Design Team. This introduces a--grid-margin-widthCSS custom property, and updates theRowandWrappercomponent width and margin calculations to take the new value into account.margin: 0to thebodyelement in the CSS resets stylesheet.