-
Notifications
You must be signed in to change notification settings - Fork 0
(components) fix/patch: various updates and improvements #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e8a8bcb
09f8c4d
0acb710
a7ffc70
e46fc45
a2837a1
3892cdb
243e15a
71526f9
17a1bb5
69af776
7db5cb3
e6b629f
16c277e
21c8650
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@wethegit/components": major | ||
| --- | ||
|
|
||
| - Removes the CSS modules file from `useBreakpoints`, due to Next JS and Turbopack no longer supporting the `:export` feature. Instead, this value is hard-coded in the `use-breakpoints.ts` file now. | ||
| - Overhauls the flex `grid-layout` system: | ||
| - Removes `Wrapper` component in favor of the new `noFlex` prop on the `Row` component. | ||
| - Removes inline padding from `Column` components, in favor of flexbox's `gap` property. Way less of a learning curve here now for newcomers. | ||
| - Adds a `flexDirection` prop to the `Flex` (and therefore the `Row`) component, to allow users to specify per-breakpoint flex directions. | ||
| - Refactors and renames the `grid-calc(n)` SCSS utility to be `get-column-width(n)`. This is more indicative of what it's used for. | ||
| - Updates the `grid-layout` system to use the latest standards created by We the Collective's Design Team. This introduces a `--grid-margin-width` CSS custom property, and updates the `Row` component's width and margin calculations to take the new value into account. | ||
| - Adds `margin: 0` to the `body` element in the CSS resets stylesheet. |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Github-flavored Markdown specifically needed to be an option under |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No more padding for gutters, so no need for this! |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| module.exports = { | ||
| extends: ["stylelint-config-custom/base"], | ||
| rules: { | ||
| "scss/operator-no-newline-after": null, | ||
| }, | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| export * from "./column" | ||
| export * from "./row" | ||
| export * from "./wrapper" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,17 @@ | ||
| @use "@local/styles/breakpoints/breakpoints-variables" as *; | ||
|
|
||
| .row { | ||
| display: block; | ||
| inline-size: min(var(--wtc-row-width, 1440px), 100%); | ||
| column-gap: var(--wtc-gutter-width); | ||
| inline-size: min(100%, var(--wtc-row-width, 1440px)); | ||
| list-style: none; | ||
| margin-inline: auto; | ||
| padding-inline: calc(var(--wtc-gutter-width, 24px) * 0.5); | ||
| } | ||
| padding-inline: var(--wtc-grid-margin-width); | ||
|
|
||
| @media #{$md-up} { | ||
| .row:not(.stackMedium) { | ||
| display: flex; | ||
| .row { | ||
| padding-inline: 0; | ||
| } | ||
| } | ||
|
|
||
| @media #{$lg-up} { | ||
| .stackMedium { | ||
| display: flex; | ||
| } | ||
| .noFlex { | ||
| display: block; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were technically wrong syntax for the scss imports, so I've updated 'em. Also added
@useinstead of@importsince SASS is deprecating that.