feat(library): make server-side caching invisible; offline is the only save#52
Merged
Conversation
…y save Reframes the UI to match the model: there's no user-facing "download/ collection". Episodes just play (cached or not); the only deliberate per-video save is "save offline to device". - video_list_tile: drop the cataloged "Download to server" button, the failed "retry", and the server downloading/pending progress+cancel badge. The only trailing affordance is the offline save/saving/saved state, and only for a cached (COMPLETE) video. Un-cached episodes show nothing (invisible caching). Removed onDownload/onCancel/downloadProgress params. - channel_detail: every episode is tap-to-play now (un-cached starts via instant-stream); removed the download handler, "Re-download" menu item, the optimistic-pending set and the 5s download-status polling. - downloads_screen -> "Offline": dropped the server-downloads section, activeDownloadsProvider and its polling; only on-device saves remain. Bottom nav tab relabeled "Offline". - websocket_provider: download_progress is now a no-op (caching is invisible); download_complete still refreshes feeds + drives auto-offline. - Removed now-unused api_service.downloadVideo/getActiveDownloads/cancelDownload and the download_progress_provider. Tests updated (a11y: offline label + un-cached shows no caching status). 156 passed; analyze + format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Client side of the invisible-caching redesign (backend: windoze95/nullfeed-backend#90). There's no longer a user-facing "download/collection" — episodes just play (cached or not), and the only deliberate per-video save is "save offline to device."
Changes
video_list_tile— removed the cataloged "Download to server" button, the failed "retry", and the server downloading/pending progress+cancel badge. The only trailing affordance is the offline save/saving/saved state, and only for a cached (COMPLETE) video; un-cached episodes show nothing (caching is invisible). Dropped theonDownload/onCancel/downloadProgressparams.channel_detail— every episode is tap-to-play now (an un-cached one starts via instant-stream); removed the download handler, the "Re-download" menu item, the optimistic-pending set, and the 5s download-status polling.downloads_screen→ "Offline" — dropped the server-downloads section,activeDownloadsProvider, and its polling; only on-device saves remain. Bottom-nav tab relabeled "Offline".websocket_provider—download_progressis now a no-op (caching is invisible);download_completestill refreshes feeds + drives auto-offline.api_service.downloadVideo/getActiveDownloads/cancelDownloadand thedownload_progress_provider.Kept
"Save for offline" (cloud icon), the offline indicator, watch-later, continue-watching. The "Remove from library" per-video action is left as-is for now (it's a removal action, not a download — flagged for a follow-up decision).
Verification
dart formatclean,flutter analyze --fatal-infos --fatal-warnings→ No issues,flutter test→ 156 passed.🤖 Generated with Claude Code