ADC-693: delete duplicate model and runtime block authoring aliases - #644
Draft
wolf75222 wants to merge 7 commits into
Draft
ADC-693: delete duplicate model and runtime block authoring aliases#644wolf75222 wants to merge 7 commits into
wolf75222 wants to merge 7 commits into
Conversation
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope delivered
This branch now removes two bounded classes of competing Python authoring routes:
pops.physics.Model.to_module();Model.lower()is the sole explicit advanced projection to an operator-firstModule;MomentModel.check();MomentModel.build()is the sole construction route;System.add_blockandAmrSystem.add_blockwrapper methods;__getattr__from restoring the nativeadd_blockABI as a compatibility fallback in either the assembling or bound lifecycle phase;ModelSpecand compiled-package installation through the existing type-dispatchedadd_equationseam;The public route remains:
Case.block(...) -> resolve -> compile -> bindBelow
pops.bind, the private Python wrapper now has one block-installation dispatcher. The C++System::add_block/AmrSystem::add_blockfunctions remain private native ABI entries consumed by that dispatcher.History preserved
master:3525467b;1961f4b1;d2166323;22881e39.No squash or history rewrite was used.
Validation on the current checkout
50 passed: legacy-route architecture, final public API, duplicate-core fences, typed time-factory selectors, ordinary Program factories, and semantic Program identity;docs/check_docs.py: 41 Markdown files verified, with one pre-existing freshness warning for the final specification dependency map;git diff --checkpassed.The previous smaller head had a fully green GitHub gate; that historical result is not claimed as proof for this refreshed head.
Explicit non-claims
This remains a bounded source slice of ADC-693 and does not close the issue.
add_equation/System/AmrSystemruntime seams still exist and require their own final cutover.add_blockABI is intentionally retained; deleting or narrowing it needs a coordinated binding/native change.series=compatibility selector.