fix(release): grant id-token: write on deploy job (unblocks OIDC)#19
Merged
Conversation
The reusable deploy workflow (wyre-technology/.github mcp-server-deploy.yml) declares id-token: write at its job level for Azure OIDC. Reusable workflows cannot request permissions the caller hasn't granted, so when my earlier refactor dropped the original inline deploy job's permissions block, the next release pipeline failed with: The nested job 'deploy' is requesting 'id-token: write', but is only allowed 'id-token: none'. Grant id-token: write + contents: read on the deploy job (job-scoped, not workflow-wide) so the called workflow can use OIDC to authenticate to Azure.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last sweep's release runs all failed with:
The nested job 'deploy' is requesting 'id-token: write', but is only allowed 'id-token: none'.The reusable deploy workflow declares
id-token: writeat its job level for Azure OIDC, but reusable workflows can only USE permissions the caller has GRANTED. My earlier refactor dropped the inline deploy job's permissions block; this PR restores it (job-scoped, not workflow-wide).After merge, the next release should actually execute the deploy job and land on
gwp-<vendor>by digest.