fix: raise ValueError for unrecognized strategy names in strategy_features()

[shauryagangrade]

Fixes #418

What

faircode/strategies.py::strategy_features() silently accepted any unrecognized strategy name. The final return list(core) is a bare else in practice - meant to handle exactly unawareness_proxy_removal, in_processing, and post_processing, but a typo like "in_procesing" fell through to the same branch and returned a wrong-but-plausible column set with no error.

Change

Replaced the bare catch-all with an explicit membership check for the three known core-only strategies, and added raise ValueError(f"unknown strategy: {strategy!r}") for anything else.

Why it matters

While faircode/benchmark.py only iterates the fixed STRATEGIES tuple today, strategy_features is a public (no leading underscore) function that anyone can import directly from a notebook, script, or future extension. A typo'd name silently produced a plausible wrong answer instead of an error.

Tests

Added two tests to tests/test_strategies.py:

• test_strategy_features_raises_on_unknown_strategy - a typo'd name ("in_procesing") raises ValueError
• test_strategy_features_raises_on_empty_string - empty string raises ValueError

All 13 tests in tests/test_strategies.py pass; ruff check is clean on both touched files.

[vercel]

@shauryagangrade is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hey @shauryagangrade, your first PR on Fair Code, that's awesome, thank you.

This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly.

If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review.

And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated.

[github-actions]

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

[Copilot]

🟡 Changes recommended

The updated core-only branch returns list(core) without deduplication, which can yield duplicate feature columns and inconsistent behavior vs the other branches.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR makes faircode.strategies.strategy_features() fail fast by raising a ValueError when given an unrecognized strategy name, preventing silent fall-through to an incorrect-but-plausible feature set.

Changes:

• Replace the previous catch-all fallback in strategy_features() with an explicit known-strategy check plus ValueError for unknown inputs.
• Add unit tests asserting ValueError is raised for an unknown strategy typo and for the empty string.

File summaries

File	Description
faircode/strategies.py	Adds explicit membership check for core-only strategies and raises on unknown strategy names.
tests/test_strategies.py	Adds tests verifying unknown/empty strategy inputs raise ValueError.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

faircode/strategies.py introduces a top-level-indented if that will cause an IndentationError / break strategy_features() at runtime.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite