Skip to content

fix: raise ValueError for unrecognized strategy names in strategy_features() #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakew7 merged 3 commits into from
Sep 3, 2026
Merged

fix: raise ValueError for unrecognized strategy names in strategy_features() #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b019af6
fix: raise ValueError for unrecognized strategy names in strategy_fea…
shauryagangrade Sep 3, 2026
00183df
Fix strategy handling for unawareness_proxy_removal
yakew7 Sep 3, 2026
9e6b7cc
Fix indentation for strategy condition check
yakew7 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion faircode/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ def strategy_features(strategy: str, core: list, proxies: list, protected: list)
return list(dict.fromkeys(core + proxies + protected))
if strategy == "unawareness":
return list(dict.fromkeys(core + proxies))
return list(core) # unawareness_proxy_removal, in_processing, post_processing
if strategy in ("unawareness_proxy_removal", "in_processing", "post_processing"):
return list(dict.fromkeys(core))
raise ValueError(f"unknown strategy: {strategy!r}")


def fit_in_processing(base_model, X_train, y_train, sensitive_train):
Expand Down
10 changes: 10 additions & 0 deletions tests/test_strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ def test_strategy_features_deduplicates_overlapping_names():
assert set(cols) == {"a", "b", "c"}


def test_strategy_features_raises_on_unknown_strategy():
with pytest.raises(ValueError, match="unknown strategy: 'in_procesing'"):
strategy_features("in_procesing", CORE, PROXIES, PROTECTED)


def test_strategy_features_raises_on_empty_string():
with pytest.raises(ValueError, match="unknown strategy: ''"):
strategy_features("", CORE, PROXIES, PROTECTED)


# ── encode_features ──────────────────────────────────────────────────────────
def test_encode_features_passes_numeric_columns_through():
df = pd.DataFrame({"age": [20.0, 30.0, 40.0]})
Expand Down