Repository navigation
ci(renovate): let the build harness merge itself - #25
Merged
Merged
Conversation
This repository was the portfolio's counter-example for the automerge preset, and sborka's own documentation cites it as such: build.yml was `workflow_dispatch` only, so a green-looking pull request meant nobody had run anything. That stopped being true when the automatic triggers went back on. build.yml runs on `pull_request` across both legs of the matrix — libmongoc 1.x on Linux, mongo-c-driver 2.x on macOS — which is the pair this repository exists to exercise, so the preset's precondition holds and is checked rather than assumed. publish.yml is still `workflow_dispatch` only, deliberately: the library goes out by decision, and nothing merged here reaches a release path on its own. Two comments that leaned on the old state are rewritten rather than left to rot: the pull-request limit, and the ktlint rule that was described as redundant and now does real work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository was the portfolio's counter-example for the automerge preset — and sborka's own
automerge-harness.jsonstill cites it by name: "mongkn is the counter-example and says so in its own config: the automatic triggers of its build workflow are commented out, only workflow_dispatch is left".That stopped being true when the automatic triggers went back on.
build.ymlruns onpull_requestacross both legs of the matrix — libmongoc 1.x on Linux, mongo-c-driver 2.x on macOS — which is the pair this repository exists to exercise. So the preset's precondition holds, and I checked it in the workflow rather than assuming it.publish.ymlis stillworkflow_dispatchonly, deliberately and unrelatedly: the library goes out by decision, and nothing merged here reaches a release path on its own.What changed
extendstakesgithub>youndie/sborka:automerge-harness, second — package rules concatenate in the order presets are named, and the harness rule has to land after the base preset's "a major of anything that ships gets a human"prConcurrentLimit, and the ktlint rule that called itself redundant and now does real workNot changed
The base-image rule still says no check on a pull request builds
ci/Dockerfile— that one I verified too, and it is still the case: the PR build runsmongo:8and docker compose, and never builds that file.A matching fix to sborka's own documentation follows separately, since it is that repository's text that names this one.