Repository navigation
feat(agent): send what is buffered when an app leaves the screen - #92
Merged
Merged
Conversation
A server is told it is going away and stop() delivers the last records; an app is backgrounded and then suspended or killed without a word, losing up to a flush interval of the records closest to the person leaving. The platform's own signal now asks for a flush, and in the browser every send is keepalive with the batch capped below that quota: sendBeacon cannot carry the key header. Refs: M-146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M-146 (research-clients K5), with one correction to K5.
A server is told it is going away and
stop()delivers the last records. An app is backgrounded and then suspended or killed without another word, losing up to one flush interval — the records closest to the person leaving.TracyDelivery.flushWhenBackgrounded(): AutoCloseablehooks the platform's own signal torequestFlush(): AndroidON_STOPof the whole process (androidx.lifecycle:lifecycle-process), iOSUIApplicationDidEnterBackgroundNotification, browservisibilitychangeto hidden andpagehide, desktop JVM a shutdown hook callingstop(). Linux/macOS native are servers here and do nothing — kore orders their shutdown.navigator.sendBeaconcannot carry headers and the key travels inX-Tracy-Key. Instead every browser send isfetchwithkeepalive(Ktor 3.6fetchOptions), and the batch is capped at 60 KiB on wasm because the keepalive quota is 64 KiB.pagehideevent delivers the batch within seconds (MockEngine). Checked the other way round: without the hook it times out.:agent:wasmJsBrowserTest,:agent:jvmTestgreen; Android and iOS compile. Not run on a device: the Android and iOS hooks only compile here; that check belongs to M-148.maxBatchBytesmust stay under the server's 64 KiB client ceiling.