Skip to content

Add changes in 2.13 dev version floating around - #2

Closed
dan-blanchard wants to merge 2 commits into
yuvadm:masterfrom
dan-blanchard:master
Closed

Add changes in 2.13 dev version floating around#2
dan-blanchard wants to merge 2 commits into
yuvadm:masterfrom
dan-blanchard:master

Conversation

@dan-blanchard

Copy link
Copy Markdown

I've just taken the code that they linked to on the Google Code page (that they never actually committed) and added it to the repo. Since Google Code is going to get shutdown soon, it seemed like a good idea.

@yuvadm

yuvadm commented Aug 14, 2015

Copy link
Copy Markdown
Owner

@dan-blanchard perhaps this is better suited to go on a 2.13 branch? I'm hesitant to merge this to master since this really is just a mirror repo (for now).

@dan-blanchard

Copy link
Copy Markdown
Author

That's a reasonable idea, although I'd be more inclined to call the branch unstable or dev or something like that, since has changes from 2.11.30 and 2.13.

Unfortunately, I don't think I can create a PR for a branch that doesn't currently exist. You should be able to create one and then follow the manual merge steps that show up in the "Merge pull request" box to merge it in there instead.

@yuvadm

yuvadm commented Aug 14, 2015

Copy link
Copy Markdown
Owner

Of course, just discussing this idea here :) If I do end up opening a dev branch I'll likely merge the #1 changes into it as well. Hopefully, we might be able to get some traction going and revive the project as a fork.

@dan-blanchard

Copy link
Copy Markdown
Author

Yeah, it might also be useful to try to join forces with the @ksamuel, because Pyped is basically the same thing, and they actually wrote unit tests.

@yuvadm

yuvadm commented Aug 14, 2015

Copy link
Copy Markdown
Owner

Cool. I didn't know about Pyped, I'd say that project probably has more traction and I wouldn't waste any more time on a NIH fork.

@dan-blanchard

Copy link
Copy Markdown
Author

That project hasn't really been updated in over a year, whereas the dev version I have here is from February. So traction is all relative here. 😄

@ksamuel

ksamuel commented Aug 15, 2015

Copy link
Copy Markdown

 I'm open to any discussion about merging projects. Pyped is quite stable, although I wish to add exception skipping to it and maybe turn on the auto print by default. Some unit tests also need updating and the doc could do with some gif. All in all, I've met 2 other projects doing the same thing so merging make sense to me. I'm currently on a trip but feel free to carry on the discussion and i'll catch up with you in a week. 14.08.2015, 23:20, "Dan Blanchard" notifications@github.com:That project hasn't really been updated in over a year, whereas the dev version I have here is from February. So traction is all relative here.

—Reply to this email directly or view it on GitHub.

@ksamuel

ksamuel commented Aug 24, 2015

Copy link
Copy Markdown

Ok, I'm more available now. What do you have in mind ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants