Add HF datalayouts#2055
Merged
Merged
Conversation
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
10 times, most recently
from
October 23, 2024 01:50
9ba4a0d to
3bed155
Compare
charleskawczynski
requested review from
Sbozzolo,
dennisYatunin and
sriharshakandala
October 23, 2024 19:59
Contributor
Author
|
cc @sriharshakandala, @dennisYatunin, @Sbozzolo, this PR may not be completely ready as I'm ironing out some issues, but can you please review the extension of our datalayouts and the design of how I've added the ability to make HF spaces? |
Closed
Fix some bugs Widen benchmarks, fix CPU-GPU dispatch Fix code loading Specialize in gpu pointwise kernels Fix adapt call Ensure has_uniform_datalayouts for cuda copyto Dont limit recursion in get_struct_linear Bump allocation limit, add mem to benchmark stencil job Specialize HF for fused kernels Simplify n_dofs Add some docs and change HorizontalLayout to horizontal_layout_type Apply formatter Revert n_ndofs simplification Add some unit tests, and fix empty field edge cases Add some comments, use todata for some broadcasted objects Forward todata, extend onExtrudedBroadcasted Apply formatter Use more non-specific DimensionMismatch error Add a new unit test Add more unit tests with edge case fixes Fix more edge cases
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
from
October 26, 2024 02:49
2d35635 to
c450698
Compare
charleskawczynski
enabled auto-merge
October 26, 2024 02:49
This was referenced Oct 26, 2024
This was referenced Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for new datalayouts:
VIJHFIJHFIHFVIHFFor these new datalayouts, and other datalayouts that end with the field index, we'll be able to add fast paths for linear indexing. This will simply involve reviving #1922, and specializing on all datalayouts with the field index at the end.
Finally, we can compare this with our
VIJFHdatalayout performance.To make this work with our existing implementation, users can now make horizontal spaces with a new keyword argument:
HorizontalLayout = DataLayouts.IJFH, which users may change toHorizontalLayout = DataLayouts.IJHFto try the new datalayout.