Repository navigation
feat(site): the header, footer, sign-in page and motif of the school designs - #1202
Merged
Merged
Conversation
…ch, the account button, the footer button and contact column, and the sign-in cards
…p, phone menu), designed footer, sign-in cards, motif and hero styling
…th its own name for screen readers (lane L3's shape)
…ts through logoFileFor, the register test knows the new keys
…the menu is folded
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 5, 2026 17:04
rubenvdlinde
added a commit
that referenced
this pull request
Oct 5, 2026
…gister 0.65.0, portal schema 0.10.0
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ❌ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-05 17:27 UTC
Download the full PDF report from the workflow artifacts.
…tal schema version test; 61 schema strings from development in Dutch
Contributor
Author
|
Three findings from the Zuiddrecht demo site work (#1206, #1208), which builds on this branch:
The PR also conflicts with development at the moment. #1206 and #1208 show this PR's diff until it lands. 🤖 Generated with Claude Code |
rubenvdlinde
added a commit
that referenced
this pull request
Oct 5, 2026
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-05 18:04 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The portal site draws the header, footer, sign-in page and motif of the four school designs (De Wilgenboom, Vaartveld College, Esdoornveen, Warmtepompacademie) and Zuiddrecht. Plan items G-01, G-02, G-03, G-04, G-07, G-08, G-18.
css/site-theme.css, a linked sheet: no bundle cost, no layout shift), from thematiq's--cn-brand-stripe-*. A set without a stripe draws nothing. Zuiddrecht: a red line under the menu (its Kop board, canvas v13) and its red, blue, red bands 6 : 3 : 1 over the footer.headerSearch.enabledoraccountLabel: search box to the portal's search page, one button to the own area while signed out, a person chip (initials, name,session.organisationName) and "Uitloggen" while signed in, a menu button on a phone. Lazy chunkcomponents/chrome/HeaderTools.vue. Other portals keep their header markup (the baseline header test still passes).ctaorcontact: brand column first (the set's light logo, text, outlined button), contact column, menus; bottom band one step darker. Other footers keep their order.site.phpnames the set's light logo and emblem (--nldesign-logo-inverse-url,--nldesign-emblem-url), resolved byPortalThemeResolver::logoVariantFileFor().components/chrome/SignInPage.vue) for a portal withauthentication.modeLabelsorsignInPage.headerSearch,accountLabel,footer.cta,footer.contact,authentication.modeLabels,authentication.signInPage, projected byPortalShellon named keys; schema strings in l10n.gridContext().signInRoutes, sonlSignIngets the portal's ways in.OpenSpec:
openspec/changes/site-chrome-follows-the-design. Contract for the learniq lane (which keys to fill, values per school): CHROME-CONTRACT in the build folder.Depends on
brand-motif-on-portals(feat(public-bridge): a portal gets the whole role layer, the brand motif and the accent from any set thematiq#1097) for the tokens. Without it this renders exactly as development does for every existing set (all new reads have fallbacks); the school sets only look right with both.resident-menu-badges-and-cards(PR L13_PR) is stacked on this branch.Verified
npm run check:specsexit 0 apart fromsite-edit-mode"the site entry stays under its budget" (it measuresjs/portaliq-site.jsand fails on any development build injs/, environmental; a production build is not run on this machine, CI measures the entry). New:tests/site-chrome.spec.mjs(12 tests); updatedsite-shell-blocks(footer shape),PortalShellTest,PortalThemeResolverTest,PortaliqRegisterConfigTest(the chrome keys validated against the real portal schema),PortalPageControllerTest.composer check:strict(once, then targeted re-runs of what it flagged): lint, phpcs, phpmd, psalm, phpstan clean; PHPUnit 2718 tests, 46 errors, all inherited (tests that need Nextcloud server classes, same count as development), the one failure it found is fixed (PortalPageControllerTest, re-run green).npm run lint0 errors,npm run format0,check:l10n-js0,check:schema-l10n0 uncovered,check:registerpass./mijn(DigiD stub) at 1440 and 390 for wilgenboom, vaartveld, esdoornveen, warmtepompacademie and zuiddrecht. Measured per set: the motif under the header and over the footer at the set's height (17, 9, 6, 5, 5 px), the set's logo in the header and its light logo in the footer, the account button in the primary colour, the cards per way in, the chip "FH Fatima Hulstkamp" with "Uitloggen".🤖 Generated with Claude Code