Repository navigation
feat(site): Mijn Zuiddrecht: the sign-in page of the design and the own area under the portal's name - #1208
Merged
Conversation
… read through /api/content/news newsItem 0.4.0 (register 0.59.0) gains public, portal and audienceLabel. PublicNewsReader serves only published items staff put on this portal, never one about single children, and only photos from the portal's own published media library.
…d for the school home pages nlQuickTasks, nlNewsList, nlNewsArticle and nlEventList load on demand. nlSignIn gains a card display and is handed the portal's own ways in; nlList draws numbered steps. OpenSpec change site-school-blocks.
…ch, the account button, the footer button and contact column, and the sign-in cards
…he theme does to buttons
… secondary-button rule can hide it
…p, phone menu), designed footer, sign-in cards, motif and hero styling
…th its own name for screen readers (lane L3's shape)
…and sign-in page this demo site builds on
…ts through logoFileFor, the register test knows the new keys
…demo site places The register moves to 0.63.0 with portal 0.10.0 and newsItem 0.4.0, so the schema keys of both merged branches reach an instance on upgrade.
…the menu is folded
… read-back proof, and the two occ commands
…link list and button link open pages of the site wherever it is served
…laration is checked against the register, the widgets and its own links
…anded) The register moves to 0.65.0 with portal 0.10.0: development is at 0.64.0, and the portal keys of site-chrome-follows-the-design reach an instance only when the version moves.
…s and link lists are readable without a role, documentation
…ows and the proof are each their own class
… own area under the portal's name
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 5, 2026 17:35
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ❌ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-05 17:57 UTC
Download the full PDF report from the workflow artifacts.
… the public site needs its own build
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 22:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
"Mijn Zuiddrecht" for the Zuiddrecht example site: the sign-in page of the approved Inloggen board, and the resident's own area under the name on the button.
OpenSpec change:
example-site-zuiddrecht(two requirements added).lib/Settings/sites/zuiddrecht.json: "Als inwoner" with DigiD and "Namens een bedrijf" with eHerkenning, the heading "Inloggen op Mijn Zuiddrecht", the introduction and the notice "Geen DigiD?". All text is the board's. The page itself is feat(site): the header, footer, sign-in page and motif of the school designs #1202'sSignInPage.withAreaName. A portal withoutaccountLabelgets the translator back unchanged.What a resident sees after signing in
Nothing in this PR builds those pages: the portal already draws them from what the installed apps contribute. With dossiq on the instance that is the overview, "Mijn zaken" and the page of one case. Read in dossiq's contribution on its development branch: the case list with case number, subject, status and "Uiterlijk klaar op", and the case page with its steps, its details ("Zaaknummer", "Onderwerp", "Status", "Toelichting op de status", "Gestart op", "Uiterlijk klaar op") and its documents. Those are the labels of the MijnZaken and Zaak boards.
Depends on
Nothing open. #1206 is merged (squash
41adb1c8) and development is merged into this branch, so the diff is this change only: 8 files. thematiq #1099 is merged too.The install never changes a portal that exists. A site installed before this change gets the cards after a remove and a new install.
Also in this PR
webpack --config webpack.site.js);npm run devbuilds the admin screens only.Verified
On head
168033eb, after development was merged in.tests/example-site.spec.mjs: 13 pass (three tests of this change: the sign-in cards against the board, the name of the own area through the realaccountCrumbsandownAreaLink, the breadcrumb rule).check:specsrun on its own, without a build injs/: 113 pass.npm run lintexit 0,formatexit 0,stylelintexit 0.origin/development): exit 0, all 86 applicable gates passed and ran.composer check:strictnot run: this change holds no PHP file.Seen live
By the coordinator on a throwaway Nextcloud with OpenRegister, on head
95c7736cof this branch: after remove and install, the "Mijn Zuiddrecht" button opens "Inloggen op Mijn Zuiddrecht" with both cards and the notice, and the breadcrumb reads "Home", "Mijn Zuiddrecht".The breadcrumb room was added after that check. It was measured in the lane's preview (this branch's CSS, the content API answered through the real
PortalShell): 16px on the waste page and the sign-in page, 5px on the home page as before.Not seen: anything signed in. The overview, the case list and the case page need an instance with dossiq, a resident account and cases.
Still to check live
Sign in as a resident with a case in dossiq (on a test instance:
occ config:app:set portaliq dev_login_enabled --value=yes). Expect the resident menu and the breadcrumb under the name "Mijn Zuiddrecht", "Mijn zaken" with the case, and its page with steps and details. And one page with a trail: the trail stands 16px under the red line.Follow-up, not in this PR
The check marks on the home page's "Mijn Zuiddrecht" card are red on the deep blue. The card draws them in the set's accent, which suits the school sets (yellow on dark) and not Zuiddrecht. It needs a token in thematiq for a mark on a dark card, and one line in
NlSignIn.vuethat reads it before the accent. The marks are decoration; the text beside them is white on #234A78, 9.04:1.Left out of the design, and why
🤖 Generated with Claude Code