Repository navigation
feat(site): the resident menu lists children with a subtitle, counts and the organisation card - #1203
Merged
Merged
Conversation
…ch, the account button, the footer button and contact column, and the sign-in cards
…p, phone menu), designed footer, sign-in cards, motif and hero styling
…from a collection, the organisation card, the phone button count
…ign' into feat/resident-menu-badges-and-cards
…th its own name for screen readers (lane L3's shape)
…ts through logoFileFor, the register test knows the new keys
…ign' into feat/resident-menu-badges-and-cards
…the menu is folded
…ign' into feat/resident-menu-badges-and-cards
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 5, 2026 17:04
…gister 0.65.0, portal schema 0.10.0
…-menu-badges-and-cards; register 0.66.0, portal schema 0.11.0
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ❌ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-05 17:31 UTC
Download the full PDF report from the workflow artifacts.
…tal schema version test; 61 schema strings from development in Dutch
…rds; portal schema 0.11.0 in the test
… into resident-menu-badges-and-cards
rubenvdlinde
added a commit
that referenced
this pull request
Oct 5, 2026
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 18:20 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The resident menu as the school designs draw it (MijnMenu boards). Plan items G-05 and G-06.
perRecordpage that declaresgrouplists each row as an item of that group with itsrecords.subtitleFieldsas a second line ("Mijn kinderen": "Vera, Groep 7 · Meester Daan"). Withoutgroupthe menu keeps a group per row.badge: {collection, label?}: the menu loads that collection with the per-record ones and shows the number of rows. The server keeps this key only once lane L2 adds it tolib/Contribution/PageMenuKeys.php(requested); until then no badge shows.accountLabeland the total of the counts ("Mijn Wilgenboom, 2 nieuw").residentMenu.cardLabel: while the session acts for an organisation (session.organisationName) the menu opens with a card ("U regelt het voor, Jansen Installatietechniek BV").OpenSpec:
openspec/changes/resident-menu-badges-and-cards.Depends on
Stacked on
feat/site-chrome-follows-the-design(#1202, merged into this branch). Merge that first; this diff then shows only the menu work. Uses thematiqbrand-motif-on-portalsfor--thematiq-accent-*and--thematiq-badge-*(fallbacks otherwise).Verified
node --test tests/resident-menu-badges.spec.mjs5 tests green;mijn-home,site-resident-menu,site-navigationgreen (one regex inmijn-homeallows the empty subline anchor).PortalShellTestgreen with the card label.PortalShell.php; the fullcheck:strictran on the base branch (feat(site): the header, footer, sign-in page and motif of the school designs #1202).group/subtitleFieldson its per-child pages and the server dropsbadgeuntil lane L2 keeps it; no session carriesorganisationName, so the card does not show. Each is covered by the node tests.🤖 Generated with Claude Code