Repository navigation
feat(settings): Gegevens van de portal as settings-form and chips-field config - #1536
Merged
Merged
Conversation
…ld config, PortalDetailsForm retired
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 12, 2026 16:55
rubenvdlinde
marked this pull request as draft
October 12, 2026 16:56
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3809/3809 · 1 skipped | ||||
| Newman | ✅ 1/1 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-12 17:00 UTC
Download the full PDF report from the workflow artifacts.
…form-details # Conflicts: # src/lib/portalDetails.js # src/widgets/PortalDetailsForm.vue
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | 🚨 NO VERDICT — enabled but never ran | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-14 09:14 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
marked this pull request as ready for review
October 14, 2026 13:40
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ❌ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3877/3877 · 1 skipped | ||||
| Newman | ✅ 1/1 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-14 13:46 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Oct 14, 2026
rubenvdlinde
added a commit
that referenced
this pull request
Oct 14, 2026
…n Nextcloud 32 to 34) (#1570) The boot test mocked getAppContainer() with a bare ContainerInterface. Nextcloud 32 to 34 declare that method as returning IAppContainer, so six PHPUnit cells failed on development 31cf029; only stable35 passed. IAppContainer extends ContainerInterface, so one stand-in fits every version. Control: a mock of an IAppContainer-typed method refuses the bare stand-in and accepts IAppContainer. Gate 102: the language and web-address chips fields from #1536 carry placeholders 'nl' and 'https://www.example.nl' without an nl.json key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Gegevens van de portal" on the portal's Instellingen tab is manifest config: one
settings-formcard (nextcloud-vue 2.83) with every field the oldPortalDetailsFormhad, saved with one Save.PortalDetailsForm.vue,src/lib/portalDetails.jsand the registry entry are deleted. Bumps @conduction/nextcloud-vue to ^2.83.0.Old form -> this form
required/patternon the fields; nothing is sent while a field is wrong.chipsfields inside the form (one form, REQ-PDE-004, the board's single card), saved with Save. Languages: at least one ("Choose at least one language."), default["nl"], free codes as the old taggable select allowed, lowercased.site) and header (double), the values the site already assumes.referencefield over this portal's published Media images (filter: {kind: image, status: published, portal: "@object.slug"}), stored as/apps/portaliq/api/content/media/{id}?portal={portal}, PLUS a typed address (free: true, "Of een webadres"). The typed value answers to^(/(?!/)\S*|https?://\S+)$: root-relative or http(s), whatPortalRuntimeConfigResolver::logoUrl()lets through.Named differences
HTTPS://) is refused; logoUrl() would accept it.Verified live (admin, open-venray, Instellingen tab, :8080, head 53c24f7)
doublefor a portal without one; the languages hint shows once (2.83 #1588).Nederlandsrefused;DEstored asde;www.example.nlrefused.{headerVariant, locales, logo: "/apps/portaliq/api/content/media/<id>?portal=open-venray", frameAncestors}, notice "De portal is opgeslagen.", API shows all four.javascript:alert(1)refused with "Een logo-adres begint met /, http:// of https://.";/apps/portaliq/logo/open-venray.svgsaved and stays selected.Gates (exit codes, head 53c24f7)
npm run build0.node --test tests/*.spec.mjs1: 1547 tests, 1546 pass, 1 inherited (example-site "the Zuiddrecht site holds what the design shows": 39 pages vs 38, from development's site JSON; this branch does not touch it).--no-coverage2: 3878 tests, 6 errors, all inheritedHostRootRedirectBootTest.Pixel PtPortalInstellingen (pieter)
9.67% before (development) -> 9.69% after (the logo card has one more input).
🤖 Generated with Claude Code