refactor(auth): replace any-cast authenticate fallback with typed appauthenticate decorator in cards, event, and nfc routes by yachikadev · Pull Request #626 · Dev-Card/DevCard

yachikadev · 2026-06-21T11:45:20Z

Summary
Replaces all (app as any).authenticate fallback chains with properly
typed preHandler — same pattern established in for team.ts.

Changes
cards.ts — auth cleanup
connect.ts — auth cleanup
event.ts — auth cleanup + fixed TS generic types on route methods
nfc.ts — auth cleanup + removed unused imports
Test Results
tsc --noEmit — 0 errors
eslint — 0 errors, 0 warnings
Tests — 69/69 passed
Closes #594

….authenticate decorator in cards, event, and nfc routes (closes Dev-Card#594)

vercel · 2026-06-21T11:45:24Z

@yachikadev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2026-06-21T11:45:33Z

Hi @yachikadev,

Thanks for opening this pull request.

This PR has been automatically classified based on the files modified.

Applied Labels

gssoc:approved
backend

Primary Review Area

backend

Reviewer

@Harxhit has been identified as the primary reviewer for this pull request.

If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer.

Thank you for your contribution!

github-actions · 2026-06-21T11:46:09Z

CI — All Checks Passed

Backend — PASS

Check	Result
Lint	PASS
Test	PASS
Typecheck	PASS

Mobile — SKIP

Check	Result
Lint	-
Test	-

Web — SKIP

Check	Result
Build	-

Last updated: Tue, 23 Jun 2026 07:16:49 GMT

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

yachikadev · 2026-06-21T11:47:46Z

@Harxhit,
the CI failure is due to @devcard/shared module not found error
which appears to be a pre-existing infrastructure issue unrelated to
my changes. Could you please check?

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

Harxhit · 2026-06-22T03:02:11Z

@Harxhit, the CI failure is due to @devcard/shared module not found error which appears to be a pre-existing infrastructure issue unrelated to my changes. Could you please check?

We have addressed it in our recent merge.

yachikadev · 2026-06-22T06:02:31Z

CI failure note — pre-existing, unrelated to this PR
The backend-ci / typecheck failure here (cards.ts(111,7) — TS2741: Property 'links' is missing in type ... but required in type 'CardResponse') is not introduced by this PR's changes.
This is a pre-existing type mismatch in cardRoutes → updateCard, where the value returned by cardService.updateCard() doesn't satisfy the CardResponse type's links field. I encountered the identical error in PR #632 as well, on an unrelated set of changes, which confirms it's broken on main independent of either PR.

Harxhit · 2026-06-22T08:07:56Z

CI failure note — pre-existing, unrelated to this PR
The backend-ci / typecheck failure here (cards.ts(111,7) — TS2741: Property 'links' is missing in type ... but required in type 'CardResponse') is not introduced by this PR's changes.
This is a pre-existing type mismatch in cardRoutes → updateCard, where the value returned by cardService.updateCard() doesn't satisfy the CardResponse type's links field. I encountered the identical error in PR #632 as well, on an unrelated set of changes, which confirms it's broken on main independent of either PR.

We have addressed it in recent merge

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

yachikadev · 2026-06-22T11:17:14Z

@Harxhit All CI checks are passing now. Could you please review when you get a chance?

Harxhit · 2026-06-23T06:39:44Z

Fix merge conflicts and pin me please .

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

yachikadev · 2026-06-23T07:17:08Z

@Harxhit done

Harxhit

LGTM. Approving

Harxhit · 2026-06-22T02:59:01Z

 import { createCardSchema ,updateCardSchema, addPlatformLinkSchema} from '../validations/card.validation';

-import type { CardResponse, UpdateCardBody, UpdatedCardResponse } from '../services/cardService';
+import type { CardResponse, UpdateCardBody } from '../services/cardService';


Why did you removed the type ```UpatedCardResponse``?

github-actions · 2026-06-23T07:23:16Z

Congratulations @yachikadev on getting PR #626 merged!

Thank you for your contribution to the project.

To receive the appropriate GSSoC labels and recognition, please mention @Harxhit in the #get-labels channel on our Discord server and share your merged PR link.

…authenticate decorator in cards, event, and nfc routes (Dev-Card#626) * refactor(auth): replace any-cast authenticate fallback with typed app.authenticate decorator in cards, event, and nfc routes (closes Dev-Card#594) * Update cards.ts Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com> * Update event.ts Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com> * Update nfc.ts Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com> * Update cards.ts Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com> --------- Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

refactor(auth): replace any-cast authenticate fallback with typed app…

589eb3e

….authenticate decorator in cards, event, and nfc routes (closes Dev-Card#594)

github-actions Bot added backend gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. labels Jun 21, 2026

yachikadev mentioned this pull request Jun 21, 2026

refactor(auth): replace any-cast authenticate fallback with typed pre… #608

Closed

Merge branch 'main' into fix/auth-cleanup-554

4a8a170

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

yachikadev added 3 commits June 21, 2026 20:45

Update cards.ts

6e19d22

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

Update event.ts

7bd6783

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

Update nfc.ts

851def8

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

yachikadev mentioned this pull request Jun 21, 2026

fix(events): add missing organizerId to response and fix incomplete test mocks causing 500 crashes #632

Merged

yachikadev mentioned this pull request Jun 22, 2026

bug: TS2741 — Property 'links' missing in CardResponse return type of updateCard route #635

Closed

Update cards.ts

e29efc4

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

Merge branch 'main' into fix/auth-cleanup-554

ed9a232

Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>

Harxhit approved these changes Jun 23, 2026

View reviewed changes

Harxhit merged commit 5f60290 into Dev-Card:main Jun 23, 2026
5 of 6 checks passed

Conversation

yachikadev commented Jun 21, 2026

Uh oh!

vercel Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

Applied Labels

Primary Review Area

Reviewer

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI — All Checks Passed

Backend — PASS

Mobile — SKIP

Web — SKIP

Uh oh!

yachikadev commented Jun 21, 2026

Uh oh!

Harxhit commented Jun 22, 2026

Uh oh!

yachikadev commented Jun 22, 2026

Uh oh!

Harxhit commented Jun 22, 2026

Uh oh!

yachikadev commented Jun 22, 2026

Uh oh!

Harxhit commented Jun 23, 2026

Uh oh!

yachikadev commented Jun 23, 2026

Uh oh!

Harxhit left a comment

Choose a reason for hiding this comment

Uh oh!

Harxhit Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 21, 2026 •

edited

Loading