fix(events): add missing organizerId to response and fix incomplete test mocks causing 500 crashes#632
Conversation
|
@yachikadev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @yachikadev, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
github-actions
Bot
added
the
gssoc:approved
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
yachikadev
force-pushed
the
fix/606-event-test-mocks
branch
from
b3a8cd7 to
890f25e
Compare
Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>
|
@Harxhit All CI checks are passing now. Could you please review when you get a chance? |
|
Congratulations @yachikadev on getting PR #632 merged! Thank you for your contribution to the project. To receive the appropriate GSSoC labels and recognition, please mention @Harxhit in the #get-labels channel on our Discord server and share your merged PR link. |
…est mocks causing 500 crashes (Dev-Card#632) * fix(events): add organizerId to EventDetails response * fix(events): fix import order and add missing organizer fields in event test * fix(event.test.ts): fix makeAttendeeRow return type annotation * fix(event.test.ts): use type import for LightMyRequestResponse Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com> --------- Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>
2 participants
Summary
Fixes two pre-existing bugs found while working on #554.
Confirmed via
git stashthat both issues predate any auth-cleanup changes.Changes
event.ts— added missingorganizerIdtoGET /api/events/:slugresponseevent.test.ts— fixed incomplete mocks:organizer: { username, displayName }to slug route mocks_count: { attendees: N }to attendees route mocks (was causing 500 crashes in 6 tests)Test Results
tsc --noEmit— 0 errorseslint— 0 errors, 0 warningsCloses #606