Skip to content

deps: pin cmeel-urdfdom<5 and cmeel-tinyxml2<11 for pinocchio#551

Merged
aristarkhovNV merged 1 commit into
mainfrom
aaristarkhov/fix-pinocchio-cmeel-pins
May 21, 2026
Merged

deps: pin cmeel-urdfdom<5 and cmeel-tinyxml2<11 for pinocchio#551
aristarkhovNV merged 1 commit into
mainfrom
aaristarkhov/fix-pinocchio-cmeel-pins

Conversation

@aristarkhovNV
Copy link
Copy Markdown
Collaborator

@aristarkhovNV aristarkhovNV commented May 21, 2026

Pinocchio 3.9.0 wheels link against liburdfdom_sensor.so.4.0 and libtinyxml2.so.10 but declare only >= floors on their cmeel packages. Upstream published cmeel-urdfdom 6.0.0 and cmeel-tinyxml2 11.0.0 on 2026-05-21; both ship newer sonames, causing import pinocchio to fail at runtime in fresh teleop_ros2 image builds.

Summary by CodeRabbit

Chores

  • Updated dependency version constraints to ensure runtime compatibility with recent library updates.

Review Change Stack

Pinocchio 3.9.0 wheels link against liburdfdom_sensor.so.4.0 and
libtinyxml2.so.10 but declare only `>=` floors on their cmeel packages.
Upstream published cmeel-urdfdom 6.0.0 and cmeel-tinyxml2 11.0.0 on
2026-05-21; both ship newer sonames, causing `import pinocchio` to fail
at runtime in fresh teleop_ros2 image builds.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c4ab7de9-f534-4df3-9b02-32427b56226e

📥 Commits

Reviewing files that changed from the base of the PR and between 8b57406 and a2c4666.

📒 Files selected for processing (1)
  • src/core/python/requirements-grounding.txt

📝 Walkthrough

Walkthrough

This PR adds upper-bound version constraints for two dependencies in the Python grounding requirements: cmeel-urdfdom<5 and cmeel-tinyxml2<11. The changes include explanatory comments documenting why these constraints are necessary for runtime compatibility with Pinocchio 3.9.0's compiled bindings and the underlying soname linkage expectations.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: pinning two dependency versions for Pinocchio compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aaristarkhov/fix-pinocchio-cmeel-pins

Comment @coderabbitai help to get the list of available commands and usage tips.

@aristarkhovNV aristarkhovNV marked this pull request as ready for review May 21, 2026 17:46
@aristarkhovNV aristarkhovNV enabled auto-merge (squash) May 21, 2026 17:46
@aristarkhovNV aristarkhovNV requested a review from jiwenc-nv May 21, 2026 18:07
@aristarkhovNV aristarkhovNV merged commit 461ff5c into main May 21, 2026
45 checks passed
@aristarkhovNV aristarkhovNV deleted the aaristarkhov/fix-pinocchio-cmeel-pins branch May 21, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants