Skip to content

revert(webclient): Revert client bump for CXR.js#552

Merged
yanziz-nvidia merged 2 commits into
mainfrom
yanziz/revert-sdk-bump
May 21, 2026
Merged

revert(webclient): Revert client bump for CXR.js#552
yanziz-nvidia merged 2 commits into
mainfrom
yanziz/revert-sdk-bump

Conversation

@yanziz-nvidia
Copy link
Copy Markdown
Contributor

@yanziz-nvidia yanziz-nvidia commented May 21, 2026

Summary by CodeRabbit

  • Chores

    • Updated CloudXR Web SDK to version 6.1.0 and adjusted supporting library versions to align with the new release
  • Style

    • Redesigned in-VR performance metrics display with improved layout, featuring stacked metric panels that clearly present Render FPS, Streaming FPS, and Pose-to-Render metrics with enhanced visual hierarchy and styling

Review Change Stack

@yanziz-nvidia yanziz-nvidia requested a review from rwiltz May 21, 2026 21:04
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a1beca98-9009-419e-8139-83a78bac877a

📥 Commits

Reviewing files that changed from the base of the PR and between e0d8250 and 8c64c85.

📒 Files selected for processing (5)
  • deps/cloudxr/.env.default
  • deps/cloudxr/webxr_client/helpers/react/CloudXRComponent.tsx
  • deps/cloudxr/webxr_client/helpers/react/PerformanceCanvasImage.tsx
  • deps/cloudxr/webxr_client/package.json
  • deps/cloudxr/webxr_client/src/CloudXRUI.tsx
💤 Files with no reviewable changes (1)
  • deps/cloudxr/webxr_client/helpers/react/PerformanceCanvasImage.tsx

📝 Walkthrough

Walkthrough

This PR downgrades the CloudXR SDK and associated React/Three.js libraries from version 6.2.0 to 6.1.0, aligning the Web SDK version across environment configuration, package metadata, and telemetry reporting. The dependency stack is correspondingly adjusted for compatibility. The PerformanceCanvasImage component (which rendered metrics as a canvas texture) is completely removed, and the performance metrics display in CloudXRUI is reimplemented using three stacked text-based metric cards.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • NVIDIA/IsaacTeleop#530: Introduced PerformanceCanvasImage component and integrated it into CloudXRUI for performance metrics rendering; this PR reverses that addition.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates a revert of an SDK version bump for the CloudXR client, which directly matches the main changes across multiple files (version downgrades from 6.2.0 to 6.1.0 and related dependency adjustments).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yanziz/revert-sdk-bump

Comment @coderabbitai help to get the list of available commands and usage tips.

@yanziz-nvidia yanziz-nvidia changed the title Revert client SDK bump for CXR.js revert(webclient): Revert client bump for CXR.js May 21, 2026
@yanziz-nvidia yanziz-nvidia enabled auto-merge (squash) May 21, 2026 21:06
@yanziz-nvidia yanziz-nvidia merged commit 3a22354 into main May 21, 2026
50 checks passed
@yanziz-nvidia yanziz-nvidia deleted the yanziz/revert-sdk-bump branch May 21, 2026 21:31
@yanziz-nvidia
Copy link
Copy Markdown
Contributor Author

6.2.0 SDK proven to have a regression that needs to be fixed first. We also should put a stable build to main instead of latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants