Skip to content

ROS: Fix controller placeholder quaternion#553

Merged
sgrizan-nv merged 1 commit into
mainfrom
sgrizan/branch5
May 22, 2026
Merged

ROS: Fix controller placeholder quaternion#553
sgrizan-nv merged 1 commit into
mainfrom
sgrizan/branch5

Conversation

@sgrizan-nv
Copy link
Copy Markdown
Collaborator

@sgrizan-nv sgrizan-nv commented May 21, 2026

Use XYZW identity ordering for missing controller orientation fields so placeholder payloads match the rest of the ROS pose conventions.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected default controller orientation values when a controller input is unavailable.

Review Change Stack

Use XYZW identity ordering for missing controller orientation fields so placeholder payloads match the rest of the ROS pose conventions.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 664b7b52-b114-424f-bf56-44c0da07c66a

📥 Commits

Reviewing files that changed from the base of the PR and between 37d3345 and 344ad01.

📒 Files selected for processing (1)
  • examples/teleop_ros2/python/messages.py

📝 Walkthrough

Walkthrough

This PR modifies a single line in examples/teleop_ros2/python/messages.py. The _as_quat helper function, which provides fallback quaternion values when controller input is absent, changes its default quaternion constant from [1.0, 0.0, 0.0, 0.0] to [0.0, 0.0, 0.0, 1.0]. Both representations correspond to identity rotations but differ in quaternion component ordering convention (scalar-first vs. scalar-last). This affects the default orientation fields emitted in the controller payload when input is missing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the quaternion used as a placeholder for missing controller orientation fields from WXYZ to XYZW ordering.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgrizan/branch5

Comment @coderabbitai help to get the list of available commands and usage tips.

@sgrizan-nv sgrizan-nv merged commit 08babf4 into main May 22, 2026
45 checks passed
@sgrizan-nv sgrizan-nv deleted the sgrizan/branch5 branch May 22, 2026 19:55
@github-project-automation github-project-automation Bot moved this from TODO to DONE in Isaac Teleop Planning May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: DONE

Development

Successfully merging this pull request may close these issues.

2 participants