Skip to content

Make use_cuda_wheels and cuda_suffixed explicit - #23472

Merged
rapids-bot[bot] merged 24 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:use_cuda_wheels-true
Aug 3, 2026
Merged

Make use_cuda_wheels and cuda_suffixed explicit#23472
rapids-bot[bot] merged 24 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:use_cuda_wheels-true

Conversation

@KyleFromNVIDIA

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

In order to support rapidsai/pre-commit-hooks#132, matrix parameters like use_cuda_wheels and cuda_suffixed have to be explicit so that the verify-dependencies hook doesn't produce false positives. Make them explicit so we can use the hook.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner July 29, 2026 16:46
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from bdice July 29, 2026 16:46
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Changes

CUDA wheel dependency alignment

Layer / File(s) Summary
CUDA-wheel matrix selectors
dependencies.yaml
Pyproject targets across cuDF-related packages now select CUDA-wheel-enabled variants and unsuffixed CUDA packages.
Package dependency selectors
dependencies.yaml
libnvcomp and CuPy selections are gated by CUDA-wheel settings, with a targeted verification exception for cudf_kafka.
Wheel build matrix
ci/build_wheel_libcudf.sh
The libcudf wheel dependency-generation matrix now includes CUDA-wheel selection, and the SPDX attribution is updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: libcudf, Python

Suggested reviewers: bdice, jameslamb, gforsyth

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely summarizes the main configuration change.
Description check ✅ Passed The description matches the changes and explains why the matrix parameters were made explicit.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@KyleFromNVIDIA KyleFromNVIDIA changed the title Make use_cuda_wheels: "true" explicit Make use_cuda_wheels and cuda_suffixed explicit Jul 29, 2026
Comment thread CONTRIBUTING.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@dependencies.yaml`:
- Line 206: Update the libcudf dependency matrix entry identified by
cuda_suffixed so it matches python/libcudf/pyproject.toml’s
cuda_suffixed=true;use_cuda_wheels=true contract, or regenerate that pyproject
metadata from the corrected matrix. Ensure generated selectors consistently
choose the CUDA-suffixed nvidia-libnvcomp wheel.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f862653a-635d-4940-b7b5-87ae814b231d

📥 Commits

Reviewing files that changed from the base of the PR and between 82a7b79 and a697892.

📒 Files selected for processing (1)
  • dependencies.yaml

Comment thread dependencies.yaml
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner July 29, 2026 18:08
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from bdice July 29, 2026 18:08

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, include some context in the PR description. I know it's for rapidsai/pre-commit-hooks#147 (comment) but I don't think anyone else reviewing or finding this from search / git blame in the future would.

I'm personally ok with our dependencies.yaml files getting a bit more verbose like this in the name of being explicit, especially if it helps us to enforce these conventions via a pre-commit hook. I'd like to hear what @bdice says too if he has time to review.

Comment thread dependencies.yaml Outdated

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KyleFromNVIDIA and @jameslamb! This looks good. I'm glad we were able to confine the changes to the wheel pipelines and avoid declaring things that touch conda.

I'm personally ok with our dependencies.yaml files getting a bit more verbose like this in the name of being explicit, especially if it helps us to enforce these conventions via a pre-commit hook. I'd like to hear what @bdice says too if he has time to review.

Yes, 100%. This is helpful for enforcing correctness!

@github-actions github-actions Bot added the Python Affects Python cuDF API. label Jul 30, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Jul 30, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 777fcd5 into NVIDIA:main Aug 3, 2026
137 of 138 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python Aug 3, 2026
rapids-bot Bot pushed a commit that referenced this pull request Aug 7, 2026
In #23472, we incorrectly used `RAPIDS_CUDA_VERSION` in `build.sh`. This variable comes from CI only and should not be required to build locally. If `RAPIDS_CUDA_VERSION` is not available, determine the CUDA version in a similar manner to rapids-build-backend: run `nvcc --version` and parse the output.

Fixes #23587

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #23588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants