ign-fail-fast#294
Open
dmortloff wants to merge 1 commit into
Open
Conversation
ETSells
requested changes
Jun 23, 2026
ETSells
left a comment
ETSells
left a comment
Member
There was a problem hiding this comment.
Two comments. Please make sure CI passes.
|
|
||
|
|
||
| if (ign_status != IGN_OK){ | ||
| error_fail_fast( ERROR_IGN_CMD_ERROR ) |
Member
There was a problem hiding this comment.
cr: semicolon. this causes a critical compiler error and the app fails to build.
| ign_status = ign_cmd_execute( subcommand_code ); | ||
|
|
||
|
|
||
| if (ign_status != IGN_OK){ |
Member
There was a problem hiding this comment.
nit: whitespace around predicate + brace on next line (coding standards/uniformity: please maintain style)
ETSells
reviewed
Jun 23, 2026
|
|
||
| if (ign_status != IGN_OK){ | ||
| error_fail_fast( ERROR_IGN_CMD_ERROR ) | ||
| } |
Member
There was a problem hiding this comment.
nit: brace should be indented four spaces (coding standards/uniformity)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added checker for ign status is not ok to fast fail
Description
See above
Issue Link
Closes #256