Skip to content

ign-fail-fast #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmortloff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ign-fail-fast #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/rev2/prelaunch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ if ( usb_detect() )
IGN_STATUS ign_status;
/* Execute subcommand*/
ign_status = ign_cmd_execute( subcommand_code );


if (ign_status != IGN_OK){

@ETSells ETSells Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace around predicate + brace on next line (coding standards/uniformity: please maintain style)

error_fail_fast( ERROR_IGN_CMD_ERROR )

@ETSells ETSells Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr: semicolon. this causes a critical compiler error and the app fails to build.

}

@ETSells ETSells Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: brace should be indented four spaces (coding standards/uniformity)

/* Return response code to terminal */
usb_transmit( &ign_status,
sizeof( ign_status ),
Expand Down
Loading