LoRa Security Fix

[Bigmouseears]

…er size

Description

A brief description of the changes in the PR

Issue Link

Please provide a link to the issue (e.g. "Closes #1").

Also, if this PR is one of multiple for this issue, link the parent if this is a child OR link
the children if this is the parent. Do not use "closes" keywords on child PRs, only use them on
the parent.

Testing

• Passes existing unit tests
• Unit tests modified (link the test changes as a child PR)
• Integration test performed

Attach any test artifacts here, if relevant.

Other

Leave any additional notes here

Reviewer Checklist

Standards

• Follows FCF Architectural Standards
• Follows SDR Coding Standards
• Code complexity/function Size is minimized
• Code is testable
• Code is readable and commented properly
• License terms are respected

Error Handling

• Potentially unsafe functions return a status code
• Error returns properly handled

Memory

• Stack allocated memory is scoped correctly
• Heap allocated memory is avoided
• Globally allocated memory is minimized except when necessary
• Pointers are used correctly
• Concurrency has been considered

Performance

• Rate limiters are respected
• Busy waiting is avoided
• "Delay" calls are not used in performance sensitive code

[ETSells]

LGTM! @266-750Balloons should approve as well since it's his component.

[ETSells]

nit: consider adding a new status entry for this particular status (something like LORA_BUFFER_UNDERSIZED). This would allow us to detect when this condition occurs in the app/mod layer, and thus we could implement fail-safe handling for this condition.

[Bigmouseears]

Oop I think I did add that, I just forgot to commit it. LORA_BUFFER_UNDERSIZED sounds like a better name than what I had originally though

[ETSells]

Yeah this looks great to me. Up to @266-750Balloons now.

[ETSells]

@266-750Balloons Stale PR: bump.

[266-750Balloons]

Looks good. Merging. Sorry for taking 50 years to review this.