Add Error_Handler backwards compatibility#98
Merged
Conversation
Contributor
|
I'd not be comfortable to jump from using legacy hot-fire-mod to development/appa branch for engine firmware. Can you create another PR that compares hot-fire-mod and development/appa? |
Member
Author
|
this new branch should literally be dev/appa merged into hotfire mod plus a one liner. Will open a branch for true comparison, 1 sec |
Member
Author
|
hot-fire-mod doesn't seem to exist on the remote 👀 |
Member
Author
Contributor
|
it should be up now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Older platforms like the ground station and liquids use a different error handler. This macro provides the functionality of our modern error handler.
Issue Link
Parent: SunDevilRocketry/Engine-Controller-Firmware#44
Testing
Attach any test artifacts here, if relevant.
Other
Leave any additional notes here
Reviewer Checklist
Standards
Error Handling
Memory
Performance