Skip to content

Add Error_Handler backwards compatibility#98

Merged
ETSells merged 1 commit into
development/appafrom
feature/ES/liquids-base-fw
Mar 24, 2026
Merged

Add Error_Handler backwards compatibility#98
ETSells merged 1 commit into
development/appafrom
feature/ES/liquids-base-fw

Conversation

@ETSells

@ETSells ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member

Description

Older platforms like the ground station and liquids use a different error handler. This macro provides the functionality of our modern error handler.

Issue Link

Parent: SunDevilRocketry/Engine-Controller-Firmware#44

Testing

  • Passes existing unit tests
  • Unit tests modified (link the test changes as a child PR)
  • Integration test performed

Attach any test artifacts here, if relevant.

Other

Leave any additional notes here

Reviewer Checklist

Standards

  • Follows FCF Architectural Standards
  • Follows SDR Coding Standards
  • Code complexity/function Size is minimized
  • Code is testable
  • Code is readable and commented properly
  • License terms are respected

Error Handling

  • Potentially unsafe functions return a status code
  • Error returns properly handled

Memory

  • Stack allocated memory is scoped correctly
  • Heap allocated memory is avoided
  • Globally allocated memory is minimized except when necessary
  • Pointers are used correctly
  • Concurrency has been considered

Performance

  • Rate limiters are respected
  • Busy waiting is avoided
  • "Delay" calls are not used in performance sensitive code

@niekky

niekky commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

I'd not be comfortable to jump from using legacy hot-fire-mod to development/appa branch for engine firmware. Can you create another PR that compares hot-fire-mod and development/appa?

@ETSells

ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

this new branch should literally be dev/appa merged into hotfire mod plus a one liner. Will open a branch for true comparison, 1 sec

@ETSells

ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

hot-fire-mod doesn't seem to exist on the remote 👀

@ETSells

ETSells commented Feb 7, 2026

Copy link
Copy Markdown
Member Author
image

@niekky

niekky commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

it should be up now.

@ETSells ETSells merged commit 1117eb6 into development/appa Mar 24, 2026
2 checks passed
@ETSells ETSells deleted the feature/ES/liquids-base-fw branch April 29, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants