Skip to content

test(rust): lock acquisition time boundaries and replay snapshot - #548

Merged
LIghtJUNction merged 1 commit into
test/rust-route-contract-coveragefrom
test/rust-acquisition-time-boundaries
Sep 30, 2026
Merged

LIghtJUNction merged 1 commit into
test/rust-route-contract-coveragefrom
test/rust-acquisition-time-boundaries

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Stacked follow-up to #542, based on its exact head a480c2bfc3aa4f5516f25ccee844ed848cd0c676. This PR targeted test/rust-route-contract-coverage to isolate the incremental test changes. It was subsequently merged into that prerequisite branch at 4aa25772586a486a55909f94ad3f8e6e4a3d5ac6; #542 remains the path to main.

  • Replace registration tests' wall-clock now + 10 seconds deadlines with explicit persisted fixture timestamps.
  • Add seven independent singleton-visit cases covering the inclusive 90-day first-touch and 30-day attribution bounds, visits just outside the windows, and the inclusive registration cutoff. Future visits must not supply attribution or consent retroactively.
  • Replay registration after a later eligible visit and compare the entire persisted attribution snapshot, not just row count.
  • Lock the fifth PostgreSQL acquisition test into the runner's exact inventory.

No production behavior, API, schema, frontend or Go changes.

Upstream relationship

LMM API-specific Rust regression tests. Depends on #542; no issue closed.

Verification

Passed locally:

  • cargo fmt --all --check (repository-pinned Rust 1.91.0)
  • python3 apps/api-rust/tests/scripts/test-new-integration-suites.py: 7 tests passed
  • bash apps/api-rust/tests/scripts/check-real-integration-gates.sh: passed, 96 ignored tests across 10 modules
  • bash -n apps/api-rust/tests/scripts/run-real-integration-gates.sh
  • git diff --check

Also passed locally on the exact published tree:

  • cargo test --locked -p lmm-api-rs --test acquisition -- --skip postgres_: 2 passed
  • cargo clippy --locked -p lmm-api-rs --test acquisition -- -D warnings
  • cargo test --locked -p lmm-api-rs --test acquisition -- --ignored --list: all 5 PostgreSQL tests compiled and listed (listing does not execute them)

Real PostgreSQL 18 integration logs for #542 at 4aa2577 confirm all 5 acquisition tests executed and passed (0 failed, 0 ignored), including the new boundary and replay assertions. Integrated commit 4aa2577 has the identical tree ff91ef2 as this PR's published 2a1e301. Local PostgreSQL was not available; database execution evidence comes from CI. The earlier #548 run was cancelled during the subsequent PR state changes.

Review scope

Searched open acquisition PRs; #542 is the existing prerequisite. Changes are limited to its test gaps and preserve the existing license and source headers. No credentials or production data are included.

@LIghtJUNction
LIghtJUNction marked this pull request as ready for review September 30, 2026 07:27
Copilot AI balanced review requested due to automatic review settings September 30, 2026 07:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@LIghtJUNction
LIghtJUNction merged commit 4aa2577 into test/rust-route-contract-coverage Sep 30, 2026
6 of 14 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-30T07:37:30.622794Z 2a1e301 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants