chore: give every workspace crate one version - #310
Merged
Merged
Conversation
`cargo publish --workspace` reads each crate's version from its own manifest, so four manifests carrying their own literal was four chances to publish a release under a version the tag did not name. Inherit from the workspace instead. The readers that parsed a crate manifest for a version now read the workspace one.
YuanYuYuan
force-pushed
the
chore/hu-version-hygiene
branch
from
August 21, 2026 08:18
06b7336 to
c7b3218
Compare
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1 of 4, replacing #301. Each slice is one concern; #301 stays open until all four land.
What this does
Every workspace crate inherits its version from
[workspace.package]instead of carrying a literal one.What fails without this
cargo publish --workspacereads each crate's version from its own manifest, not from the release tag. A crate carrying a literal version is one a release can leave behind: it either republishes a version crates.io already has, failing the job, or ships a number that disagrees with the tag. Four crates carried one.Two riders, disclosed
Both are inseparable from the change and are not version hygiene.
sha2added tohiroz-unionhu plugin installhumble = []feature removed fromhiroz-union-p hiroz-union; every--features humbletargetshirozorhiroz-testsBreaking Changes
None. The published version is unchanged.