feat: enable cuinterpose for annotated Pods - #222
Closed
galletas1712 wants to merge 1 commit into
Closed
galletas1712 wants to merge 1 commit into
galletas1712 wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
from
September 11, 2026 02:23
4da79ac to
905e82b
Compare
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
from
September 11, 2026 06:10
905e82b to
9f5e073
Compare
galletas1712
added this pull request to stack #293
September 11, 2026 06:11
This was referenced Sep 11, 2026
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
from
September 11, 2026 06:16
9f5e073 to
913ecd2
Compare
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
from
September 11, 2026 06:21
913ecd2 to
30be555
Compare
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
2 times, most recently
from
September 11, 2026 08:31
9d017d7 to
244f06e
Compare
Add the nvidia.com/cuinterpose=enabled workload contract. The annotation only puts Snapshot's already-mounted libcuinterpose.so first in LD_PRELOAD for every checkpoint target; CUDA-tool delivery is unconditional and cuda-checkpoint --launch-job wrapping remains conditional on the target's GPU count. Shape the contract atomically, preserve existing LD_PRELOAD entries, reject ambiguous or valueFrom-based preload settings, and verify the preload before adopting an existing source Job. Record the opt-in in the checkpoint manifest so restore rejects a destination that cannot recreate the cuinterpose runtime. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
galletas1712
force-pushed
the
feat/cuinterpose-shim-delivery
branch
from
September 11, 2026 10:08
244f06e to
f4963ad
Compare
This was referenced Sep 12, 2026
This was referenced Sep 16, 2026
Contributor
Author
|
Superseded by the replacement 13-PR C-frontend/Rust-backend cuinterpose draft stack: https://github.com/ai-dynamo/snapshot/stack/339 (#326–#338), tracking approved proposal #295. The new stack preserves one reviewable stage per PR, with tests collected in #338 and the design in #337. PageBroker transfer changes remain a separate dependency. Closing this older C implementation; retaining its branch and discussion for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 3 of the eleven-PR cuinterpose stack #293. Closed PR #214 is intentionally not in the active stack.
This PR introduces the explicit workload opt-in and makes the shim part of each target process from startup:
An absent annotation disables interposition; any other present value is rejected. CUDA tool delivery and multi-GPU launch wrapping are independent contracts owned by #213. For an enabled template,
ShapeCuinterposeCaptureonly places/tmp/snapshot-cuda/libcuinterpose.sofirst in each target'sLD_PRELOAD. Existing preload entries are retained, duplicates are removed, and avalueFrom-backedLD_PRELOADis rejected because it cannot be rewritten safely. The annotation does not cause a one-GPU target to usecuda-checkpoint --launch-job.The shape is idempotent and mutates only a deep copy until every check succeeds. The operator verifies the immutable contract before adopting an existing source Job and records the opt-in annotation on the generated
PodSnapshot.At this layer the packaged shim is still a placeholder. The durable contribution is the process-start contract: later layers can intercept each target process and CUDA-using fork child from its first CUDA operation.
Stack boundary
Based on #213. #223 adds agent-side detection and coordinator invocation. This PR does not start shim sockets, assign participant identities, or alter CUDA behavior.
Validation
On the final stack,
make testpasses inapi,agent, andoperator. The pinned CUDA 13.1 builder compiles the production binaries and passes all cuinterpose fake-driver suites. The final published stack head0eae9c4f9b66093332f00a332afaf56048e1e64apassed the fullmake checkgate, the CUDA 13.1 production build, and all 73 sanitizer-backed native cuinterpose tests. Its physical-GPU suite passed all 3 tests with no skips on two DRA-assigned NVIDIA B200 GPUs. The unicast test kept an explicit allocation-ID ticket-backed peer mapping per worker live across capture and restore; the multicast test required a nonzero multicast VA and shim-logical handle, exercisedBindAddr, and passed its collective and captured-graph replay. Detailed hardware evidence and measurements are in #220.