ROM soak: stop 5° short of every joint limit - #327
Merged
Merged
Conversation
rom.enable swept each joint to its exact limit and held it there for the waypoint pause, parking the joint against its end of travel on every cycle of a two-hour soak and overtorquing the motors. Sweep extremes are now inset by ROM_LIMIT_MARGIN (5°) on both sides; the robot-wide limits in robot/axol.py are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
shawnpatel
added a commit
that referenced
this pull request
Sep 25, 2026
#327 inset every joint's sweep by ROM_LIMIT_MARGIN. Only wrist_2 and wrist_3 need it; the shoulders, elbow and wrist_1 go back to sweeping their full limits as before. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rom.enableused to sweep each joint to its exact limit and hold it there for the waypoint pause. That pushed the joint into its end of travel on every cycle of the two-hour soak and overtorqued the motors.ROM_LIMIT_MARGIN). The limits are inset locally inenable.py; the real limits inrobot/axol.pyare unchanged, so teleop is unaffected.docs/cli/diag-rom-enable.mdx.Test plan
tests/test_rom_limit_margin.pyruns one full sweep cycle (with and without the shoulder_3 mirror). It checks that no sweep end point comes within 5° of a limit on either arm, and that each joint still reaches its inset end points.uv run pytest(1594 passed),ruff check .,ruff format --check .diag.rom-enable🤖 Generated with Claude Code
Note
Medium Risk
Changes commanded joint positions during a long hardware soak; scope is diagnostics-only and limits in
robot/axolare untouched, but incorrect margin logic could reduce ROM coverage or still stress joints at the bench.Overview
The two-hour ROM soak (
diag.rom-enable) no longer commands joints to their exact mechanical limits at each sweep waypoint. Sweep endpoints are inset byROM_LIMIT_MARGIN(5°) on both sides via a local_inset()wrapper around the canonical limits inrobot/axol, so waypoint holds do not park motors against end stops for the full pause cycle.Teleop and shared limit definitions are unchanged—only the diagnostic ROM module uses the inset ranges. Module and CLI docs now describe the margin behavior.
Tests mock one full
run_rom_cycleand assert sweep targets stay at least 5° insidearm_limitswhile still hitting the inset extremes (with and without shoulder_3 mirroring).Reviewed by Cursor Bugbot for commit 260fa93. Configure here.