P5 MoFlow run-to-run null 결과 확보 + 감사 스크립트 버그 수정 (BIOP01-63) - #17
Merged
kakyungkim merged 1 commit intoAug 6, 2026
Merged
Conversation
run1/run2 재적합 완료, 판정 MOFLOW-REPRODUCIBLE (재현성 천장 +0.9999 >> 근접-0 세 쌍 중심화 코사인 |값| 최댓값 0.0118) — REVIEW-GB-2026-07-19b MAJOR-1 (1) 해소. recompute_shuffle_delta()가 moflow_scrambled.h5ad에 없는 유전자를 걸러내지 않고 조회해 죽던 버그를, 메인 재현성 천장 루프에 이미 있던 gene-set 교집합 가드와 같은 패턴으로 수정. 봉인 판정 기준(runs/near_zero_pairs_centered)에는 영향 없음 — 이 함수 결과는 §3 대조용 재현 확인일 뿐 판정에 쓰이지 않는다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
● ## 요약
p2_moflow_runtorun_refit.py --runs 2 --gpu실행 완료 (run1, run2 둘 다 세포집합이 legacymoflow.h5ad와 일치)p10g_moflow_runtorun_null_audit.py실행 → 판정: MOFLOW-REPRODUCIBLE불안정으로 설명되지 않음
velocity_matrix_audit.md§6)과 정합버그 수정
recompute_shuffle_delta()가moflow_scrambled.h5ad에 없는 유전자(CLEC7A등)를 걸러내지 않고 조회하다KeyError로 죽는 문제를,메인 재현성 천장 루프에 이미 있던 gene-set 교집합 가드와 같은 패턴으로 수정. 봉인 판정 기준(
runs,near_zero_pairs_centered)은 이함수 결과와 무관하며, §3은 대조용 재현 확인일 뿐이라 판정 로직 자체는 변경 없음.
산출물
results/moflow_runtorun_null.md/.json(신규)results/moflow_runtorun_refit/moflow_rr_run{1,2}_genes.csv(신규)results/runtime.csv(append)Test plan
p2_moflow_runtorun_refit.py --runs 2 --gpu정상 완료, 세포집합 assert 통과p10g_moflow_runtorun_null_audit.py정상 완료,moflow_runtorun_null.json/.md생성 확인draft_v2.md/draft_v2_ko.md+ response-to-reviewers에 해소된 MAJOR-1 반영Jira: BIOP01-63