Add disabled Amsterdam spec tests - #2535
Open
ryankeleti wants to merge 1 commit into
Open
ryankeleti wants to merge 1 commit into
ryankeleti wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to test fixture wiring/exclusions and keep the suite intentionally disabled, with only a minor exclusion/comment consistency issue to address.
Pull request overview
This PR updates the MONAD_NEXT Amsterdam spec-test harness to pull a consolidated fixtures bundle and keeps the entire Amsterdam suite disabled by default (to be enabled later as part of a larger PR stack).
Changes:
- Replace separate Amsterdam + EIP-7981 fixture downloads with a single combined fixtures tarball.
- Disable all Amsterdam blockchain tests via a
BlockchainTests.*exclusion wildcard, keeping the ctest job in a controlledWILL_FAILstate. - Remove the extra
--blockchain-testsdirectory argument tied to the deleted EIP-7981 fixture project.
Verdict: CORRECT
File summaries
| File | Description |
|---|---|
| test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake | Switch exclusion list to fully disable the suite via BlockchainTests.* (and adjust notes around future re-enable). |
| test/ethereum_test/CMakeLists.txt | Point ExternalProject to a consolidated fixtures release and simplify the MONAD_NEXT Amsterdam test invocation accordingly. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Baltoli
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
2 times, most recently
from
September 4, 2026 10:27
545b3fd to
5d1bdf2
Compare
ryankeleti
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
from
September 4, 2026 12:10
5d1bdf2 to
a24237c
Compare
This was referenced Sep 4, 2026
Baltoli
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
4 times, most recently
from
September 8, 2026 13:51
5fc8443 to
2abe9be
Compare
ryankeleti
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
from
September 8, 2026 14:40
2abe9be to
3f2aa90
Compare
Baltoli
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
2 times, most recently
from
September 9, 2026 09:48
c766175 to
c7ffc76
Compare
Baltoli
requested review from
a team,
andreaslyn,
brett-monad,
cmcl,
dhil,
goodlyrottenapple,
khordadi,
m-alvarez and
mkolosick
September 9, 2026 10:51
Baltoli
approved these changes
Sep 9, 2026
dhil
approved these changes
Sep 9, 2026
m-alvarez
approved these changes
Sep 9, 2026
Baltoli
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
2 times, most recently
from
September 10, 2026 10:50
49df480 to
b47c7a1
Compare
ryankeleti
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
from
September 10, 2026 16:43
b47c7a1 to
33ded1a
Compare
Baltoli
force-pushed
the
ryan/exclude-amsterdam-spec-tests
branch
from
September 14, 2026 12:24
33ded1a to
8fbd9c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be added in the mega Amsterdam PR stack