Skip to content

Add disabled Amsterdam spec tests - #2535

Open
ryankeleti wants to merge 1 commit into
mainfrom
ryan/exclude-amsterdam-spec-tests
Open

ryankeleti wants to merge 1 commit into
mainfrom
ryan/exclude-amsterdam-spec-tests

Conversation

@ryankeleti

Copy link
Copy Markdown
Contributor

To be added in the mega Amsterdam PR stack

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to test fixture wiring/exclusions and keep the suite intentionally disabled, with only a minor exclusion/comment consistency issue to address.

Pull request overview

This PR updates the MONAD_NEXT Amsterdam spec-test harness to pull a consolidated fixtures bundle and keeps the entire Amsterdam suite disabled by default (to be enabled later as part of a larger PR stack).

Changes:

  • Replace separate Amsterdam + EIP-7981 fixture downloads with a single combined fixtures tarball.
  • Disable all Amsterdam blockchain tests via a BlockchainTests.* exclusion wildcard, keeping the ctest job in a controlled WILL_FAIL state.
  • Remove the extra --blockchain-tests directory argument tied to the deleted EIP-7981 fixture project.

Verdict: CORRECT

File summaries
File Description
test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake Switch exclusion list to fully disable the suite via BlockchainTests.* (and adjust notes around future re-enable).
test/ethereum_test/CMakeLists.txt Point ExternalProject to a consolidated fixtures release and simplify the MONAD_NEXT Amsterdam test invocation accordingly.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake Outdated
Comment thread test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake
@Baltoli
Baltoli force-pushed the ryan/exclude-amsterdam-spec-tests branch 2 times, most recently from 545b3fd to 5d1bdf2 Compare September 4, 2026 10:27
@ryankeleti
ryankeleti force-pushed the ryan/exclude-amsterdam-spec-tests branch from 5d1bdf2 to a24237c Compare September 4, 2026 12:10
@Baltoli
Baltoli force-pushed the ryan/exclude-amsterdam-spec-tests branch 4 times, most recently from 5fc8443 to 2abe9be Compare September 8, 2026 13:51
@ryankeleti
ryankeleti force-pushed the ryan/exclude-amsterdam-spec-tests branch from 2abe9be to 3f2aa90 Compare September 8, 2026 14:40
@Baltoli
Baltoli force-pushed the ryan/exclude-amsterdam-spec-tests branch 2 times, most recently from c766175 to c7ffc76 Compare September 9, 2026 09:48
@Baltoli
Baltoli force-pushed the ryan/exclude-amsterdam-spec-tests branch 2 times, most recently from 49df480 to b47c7a1 Compare September 10, 2026 10:50
@ryankeleti
ryankeleti force-pushed the ryan/exclude-amsterdam-spec-tests branch from b47c7a1 to 33ded1a Compare September 10, 2026 16:43
@Baltoli
Baltoli force-pushed the ryan/exclude-amsterdam-spec-tests branch from 33ded1a to 8fbd9c2 Compare September 14, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants