Implement new control API by danth · Pull Request #489 · eclipse-score/lifecycle

danth · 2026-08-18T13:05:57Z

This pull request adapts the launch manager (and tests) to use the new control API based on mw::com, and removes the old API.

Notable points

The State_Manager application type is now aliased to Reporting_and_Supervised.

Instead, mw::com access control must be used to prevent unwanted processes acting as state managers.
There is a workaround to make the process_fd_leak test pass, because there is no possibility to set O_CLOEXEC on mw::com's file descriptors when they are created.

I've opened an issue to fix this upstream: Set CLOEXEC on file descriptors communication#1064
External documentation needs to be updated before this is released.

Relevant issues

github-actions · 2026-08-18T13:07:58Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 888f0780-f607-43de-9fe8-7fb3cd200f21
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (51 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 737 targets configured)

Analyzing: target //:license-check (156 packages loaded, 4383 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8562 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9368 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9541 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11426 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[12 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.810s, Critical Path: 0.69s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

WilliamRoebuck

A really great implementation, I have some small cleanup suggestions. I also rambled a bit about the API but I understand I may be a bit late on this so apologies if it's not relevant. As I'll be away from tomorrow, just comment and resolve if you disagree or I've misunderstood

This works around the `Graph` class not being thread safe.

This resolves several edge cases which the new version did not handle properly.

danth · 2026-09-16T09:25:05Z

+
+    ~ControlProvider() = default;
+
+    // Cannot be moved because callbacks capture the ControlProvider by reference.


I am not sure if the comment in the code is quite correct. Previously, launch manager would segfault after the ControlProvider was moved. I am only assuming that this is the explanation.

Because of this restriction, ControlProvider::Create has to allocate and return a reference. It would be good to avoid it if anyone knows how...

danth · 2026-09-16T12:52:34Z

Explanation of how get_active_run_target is handled:

MaciejKaszynski · 2026-09-16T09:47:34Z

        case fb::ApplicationType::State_Manager:
-            return ApplicationType::StateManager;
+            // These are now equivalent as access control is done via mw::com
+            return ApplicationType::ReportingAndSupervised;


I wonder if it would still make sense to keep all of this to somehow limit who can change run targets?

This needs to be done through mw::com access control.

See also this and this.

MaciejKaszynski · 2026-09-16T11:16:37Z

+namespace score::mw::lifecycle::internal
+{
+
+class IControllableGraph


Not sure about this name, Maybe something like IComponentController? Probably should also be in process_group_manager

MaciejKaszynski · 2026-09-16T11:22:10Z

+namespace score::mw::lifecycle::internal
+{
+
+class ControlProvider


Would be good to also add a brief for what the class does

MaciejKaszynski · 2026-09-16T11:25:29Z

+    }
+    LmControlSkeleton skeleton = std::move(skeleton_result).value();
+
+    auto* control_provider = new ControlProvider{std::move(skeleton), graph};


why allocate this? could just create and move into Result

MaciejKaszynski · 2026-09-16T12:00:29Z

+
+    const std::optional<IdentifierHash> new_state = IdentifierHash::if_exists(request.run_target_name.data());
+    if (!new_state.has_value())
+    {


Think logging errors would also be a good idea here.

MaciejKaszynski · 2026-09-16T12:10:26Z

+    }
+
+    const std::lock_guard<std::mutex> lock(IdentifierHash::get_registry_mutex());
+    const std::string& name = IdentifierHash::get_registry()[result.value().data()];


could you make a Result<std::string_view> IdentifierHash::get_name(IdentifierHash) method as this can throw? originally I think the registry was made just for logging but since its becoming needed for the internal logic I think making it safer would be a good idea.

MaciejKaszynski · 2026-09-16T12:11:55Z

+    ControlProvider& operator=(const ControlProvider&) = delete;
+    ControlProvider operator=(ControlProvider&&) = delete;
+
+  private:


Can you go through and check which methods can be marked as noexcept? I think probably all methods here should be?

MaciejKaszynski · 2026-09-16T12:36:32Z

    IdentifierHash process_identifier;
 };

+struct [[nodiscard]] GetActiveRunTarget


Need briefs

MaciejKaszynski · 2026-09-16T12:40:52Z

+        const IdentifierHash state = getProcessGroupState();
+
+        RunTargetActivationSource source;
+        if (is_initial_state_transition_)


think this is clang-tidy warning to not have braces around the if

hskang-amelia · 2026-09-16T13:47:52Z

    {
+        // This verifies that a fallback process was actually started - the launch manager
+        // did not just send an event without taking the action.
        EXPECT_TRUE(std::filesystem::exists(fallback_file)) << "Fallback run target should have been activated";


Some test drivers verify activation via a marker file on disk (e.g. EXPECT_TRUE(std::filesystem::exists(fallback_file))). Now that get_active_run_target() exists, could tests assert against client->get_active_run_target() instead — checking the daemon's own state rather than a side effect? Not a blocker, could be a fast-follow.

Yes, this can be cleaned up as a follow-up.

See also.

github-project-automation Bot added this to LCM - Lifecycle & Health FT Aug 18, 2026

danth requested a deployment to workflow-approval August 18, 2026 13:06 — with GitHub Actions Waiting

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Aug 18, 2026

danth force-pushed the control-api branch from 5f71352 to 4c6a6dd Compare August 18, 2026 13:39

danth requested a deployment to workflow-approval August 18, 2026 13:40 — with GitHub Actions Waiting

danth force-pushed the control-api branch from 4c6a6dd to 4cf8003 Compare August 18, 2026 13:42

danth requested a deployment to workflow-approval August 18, 2026 13:42 — with GitHub Actions Waiting

danth force-pushed the control-api branch from 4cf8003 to 6d66251 Compare August 19, 2026 08:17

danth requested a deployment to workflow-approval August 19, 2026 08:17 — with GitHub Actions Waiting

danth force-pushed the control-api branch from 6d66251 to bf414e3 Compare August 19, 2026 10:01

danth requested a deployment to workflow-approval August 19, 2026 10:01 — with GitHub Actions Waiting

danth force-pushed the control-api branch from bf414e3 to 9ab729f Compare August 19, 2026 13:32

danth requested a deployment to workflow-approval August 19, 2026 13:33 — with GitHub Actions Waiting

NicolasFussberger mentioned this pull request Aug 20, 2026

ControlClient: expose GetInitialMachineStateTransitionResult() and GetExecutionError() from ControlClientImpl to the public API #495

Closed

hskang-amelia mentioned this pull request Aug 21, 2026

Initial mw::com-based implementation of ilmcontrol interface #478

Merged

danth force-pushed the control-api branch from 9ab729f to 0ef7e8b Compare August 21, 2026 15:00

danth requested a deployment to workflow-approval August 21, 2026 15:00 — with GitHub Actions Waiting

NicolasFussberger reviewed Aug 24, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp Outdated

NicolasFussberger reviewed Aug 24, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp Outdated

danth force-pushed the control-api branch from 0ef7e8b to 8f07662 Compare August 24, 2026 07:55

danth requested a deployment to workflow-approval August 24, 2026 07:55 — with GitHub Actions Waiting

WilliamRoebuck reviewed Sep 7, 2026

View reviewed changes

SimonKozik reviewed Sep 7, 2026

View reviewed changes

Comment thread examples/control_application/control_daemon.cpp

This was referenced Sep 7, 2026

New control API is difficult to use #611

Open

Add IdentifierHash::if_exists #615

Merged

SimonKozik reviewed Sep 9, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/configuration/details/flatbuffer_type_converters.cpp

Comment thread score/launch_manager/src/daemon/src/control/details/control_provider.cpp Outdated

danth mentioned this pull request Sep 9, 2026

Set CLOEXEC on file descriptors eclipse-score/communication#1064

Open

2 tasks

NicolasFussberger reviewed Sep 10, 2026

View reviewed changes

Comment thread examples/control_application/control_daemon.cpp Outdated

hskang-amelia reviewed Sep 10, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp Outdated

NicolasFussberger requested changes Sep 10, 2026

View reviewed changes

hskang-amelia reviewed Sep 10, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp Outdated

danth mentioned this pull request Sep 10, 2026

Split activate_run_target into two methods #621

Closed

hskang-amelia reviewed Sep 10, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/process_group_manager/process_group_manager.cpp Outdated

danth added 12 commits September 16, 2026 10:18

Delete old control interface

6b64efc

Update tests to use new control interface

c1b98d8

Implement new control interface

3085b32

Refactor control implementation into new class

d415623

Use event queue for Graph access

0393f0f

This works around the `Graph` class not being thread safe.

Work around eclipse-score/communication#1064

d7cbda7

Make get_active_run_target use const

2d82ebc

Use an error rather than an assertion for the unimplemented method

513a8db

Rename methods to camel case

6df7bd1

Restore original code structure for incoming requests

f4cc324

This resolves several edge cases which the new version did not handle properly.

Return kActivationInProgress for any graph state other than kSuccess

844a663

Return errors during ControlProvider construction

1c243af

danth commented Sep 16, 2026

View reviewed changes

This was referenced Sep 16, 2026

Remove allocation in ProcessGroupManager getters/setters #641

Open

Implement queue for run target requests #643

Open

MaciejKaszynski reviewed Sep 16, 2026

View reviewed changes

hskang-amelia approved these changes Sep 16, 2026

View reviewed changes


		~ControlProvider() = default;

		// Cannot be moved because callbacks capture the ControlProvider by reference.

Uh oh!

Conversation

danth commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable points

Relevant issues

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danth Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danth commented Sep 16, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danth commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

danth Sep 16, 2026 •

edited

Loading