-
Notifications
You must be signed in to change notification settings - Fork 34
Implement new control API #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaciejKaszynski
merged 18 commits into
eclipse-score:main
from
etas-contrib:control-api
Sep 17, 2026
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fd2d39d
Delete old control interface
danth bff2fae
Update tests to use new control interface
danth e72d26a
Implement new control interface
danth a0baf00
Refactor control implementation into new class
danth c4d9f6a
Use event queue for `Graph` access
danth 3bb8e1b
Work around eclipse-score/communication#1064
danth a643d37
Make `get_active_run_target` use `const`
danth 4ad3e56
Use an error rather than an assertion for the unimplemented method
danth 41f63f4
Rename methods to camel case
danth b2c2216
Restore original code structure for incoming requests
danth abefdbe
Return `kActivationInProgress` for any graph state other than `kSuccess`
danth e87455c
Return errors during ControlProvider construction
danth aa6a1aa
Log errors during activation requests
danth d77d385
Rename `IControllalbeGraph` to `IRunTargetControl`
danth 8b08d2e
Pass through the error code from inner methods
danth c09ecf5
Mark `ControlProvider` and `IRunTargetControl` methods as `noexcept`
danth 6b9d0cf
Stabilise `fallback_to_same_target_restarts` test
danth cf2a848
Use constant for the name of the recovery state
danth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
85 changes: 0 additions & 85 deletions
85
score/launch_manager/src/control_client/src/control_client.cpp
This file was deleted.
Oops, something went wrong.
101 changes: 0 additions & 101 deletions
101
score/launch_manager/src/control_client/src/control_client.h
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.