Repository navigation
Preserve author-added empty lines between promoted constructor properties - #159
Merged
TomasVotruba merged 1 commit intoOct 7, 2026
Merged
Conversation
TomasVotruba
deleted the
preserve-empty-lines-standalone-promoted-property
branch
October 7, 2026 19:34
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StandaloneLinePromotedPropertyFixercollapsed intentional empty lines between promoted constructor properties. After each comma,TokensNewliner::breakItems()forced exactly one newline viaensureWhitespaceAtIndex(), wiping any blank line the author added to visually group#[Autowire(...)]properties.Example that got mangled:
Fix
Skip whitespace normalization after a comma when the following whitespace already contains a blank line (2+ line endings). Single-line argument lists are still broken onto standalone lines as before.
Added fixture covering empty lines between attributed promoted properties.