Repository navigation
Build blink binaries from local blink/ module in release - #93
Merged
Merged
Conversation
The release build now compiles the per-platform blink binaries from the ported blink/ module instead of cloning the external ecs-go repository, so the shipped --blink runner reflects the code in this repository. - release step builds bin/blink-<os>-<arch> from blink/, drops the external clone - remove the obsolete bin/turbo directory from the deployed repo - EcsGoBinaryLocator resolves the bundled bin/blink-<platform> - bin/blink wrapper execs the bundled binary, building from blink/ only in the source repo
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #92. The release build shipped the
--blinkGo binaries by cloning the externalTomasVotruba/ecs-gorepository, so the portedblink/module in this repo never reached the deployedecsphp/ecs. This wires the release to build fromblink/instead.Changes
.github/workflows/buid_release.yaml- step 5b buildsbin/blink-<os>-<arch>(6 platforms) from the localblink/module; thegit clone TomasVotruba/ecs-goand thebin/turbodirectory are gone. The obsoletebin/turbois also removed from the deployed repo so stale binaries do not linger.src/Turbo/EcsGoBinaryLocator.php- resolves the bundledbin/blink-<platform>, falls back tovendor/bin/blinkandblinkon PATH; the not-found message points at the localblink/build instead of the external repo.bin/blink- execs the bundledbin/blink-<platform>in a release; builds fromblink/on first run only in the source repo.Layout in the deployed repo
Local checks pass: PHPStan, Rector, ECS, and the Turbo unit tests. The wrapper builds and runs from
blink/in the source checkout (209 fixers).