fix: low-priority fixes from review (PR #139 manual)#144
Merged
Conversation
- CI matrix: add Python 3.14 - InMemoryCommentRepository.find_all_by_note: sort by id for deterministic ordering - AppSettings: add app_env validator (restrict to local/test/production) - export_openapi.py: fix docstring command path - mcp.py: add reason comment to all type: ignore[type-arg] suppression Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemoryCommentRepository.find_all_by_note()now returns comments sorted byid(deterministic ordering)AppSettings.app_envvalidated against{"local", "test", "production"}— rejects typos at startupexport_openapi.pydocstring corrects the invocation commandmcp.py: all 15# type: ignore[type-arg]suppressions now include a# reason:commentNote
PR #139 (
fix/128-132-low-priority-fixes) was accidentally skipped in the batch merge. Itsmcp.pydiff conflicted with the typed-DTO changes from PR #142, so this branch applies the changes manually against current main.Test plan
uv run pytest— 178 passeduv run mypy src/— no issuesuv run ruff check src/ tests/— all checks passed🤖 Generated with Claude Code