Conversation
arome
requested review from
alexdunae,
aruniverse,
ben-polinsky,
kckst8,
toddsouthenbentley,
veekeys and
williamkbentley
as code owners
September 2, 2026 19:28
arome
force-pushed
the
omar/manage-versions-eslint-fix
branch
from
September 2, 2026 19:30
27dc669 to
4e8648b
Compare
arome
enabled auto-merge (squash)
September 2, 2026 19:30
ben-polinsky
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test TypeScript configuration contains incompatible module settings that produce TS5110.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Manage Versions lint/test configuration and stabilizes virtualized-row testing.
Changes:
- Includes test files in ESLint analysis.
- Adds dedicated test TypeScript configurations.
- Waits for virtualized rows before assertions.
- Records the change metadata.
File summaries
| File | Review |
|---|---|
packages/modules/manage-versions/tsconfig.test.json |
Critical: moduleResolution: "Node16" requires matching module: "Node16"; "CommonJS" causes TS5110. |
packages/modules/manage-versions/tsconfig.eslint.json |
Includes tests while excluding generated output. |
packages/modules/manage-versions/src/tsconfig.json |
Defines focused test-file configuration. |
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.test.tsx |
Stabilizes virtualized-row assertions. |
common/changes/@itwin/manage-versions-react/omar-manage-versions-eslint-fix_2026-09-02-19-32.json |
Records the non-release change. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ben-polinsky
approved these changes
Sep 3, 2026
alexdunae
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation