Skip to content

Fix manage-versions ESLint config and flaky test - #232

Open
arome wants to merge 4 commits into
mainfrom
omar/manage-versions-eslint-fix
Open

arome wants to merge 4 commits into
mainfrom
omar/manage-versions-eslint-fix

Conversation

@arome

@arome arome commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix the ESLint TypeScript project config so the package includes test files without inheriting build-time exclusions.
  • Add a focused tsconfig for package test files.
  • Stabilize the flaky virtualized row assertion in the ManageVersions test.

Validation

  • Ran ESLint on the manage-versions package and confirmed the parser error is resolved.
  • The package lint reports only existing warnings, with no lint errors.

@arome
arome force-pushed the omar/manage-versions-eslint-fix branch from 27dc669 to 4e8648b Compare September 2, 2026 19:30
@arome
arome enabled auto-merge (squash) September 2, 2026 19:30
Comment thread packages/modules/manage-versions/src/tsconfig.json Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test TypeScript configuration contains incompatible module settings that produce TS5110.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Manage Versions lint/test configuration and stabilizes virtualized-row testing.

Changes:

  • Includes test files in ESLint analysis.
  • Adds dedicated test TypeScript configurations.
  • Waits for virtualized rows before assertions.
  • Records the change metadata.
File summaries
File Review
packages/modules/manage-versions/tsconfig.test.json Critical: moduleResolution: "Node16" requires matching module: "Node16"; "CommonJS" causes TS5110.
packages/modules/manage-versions/tsconfig.eslint.json Includes tests while excluding generated output.
packages/modules/manage-versions/src/tsconfig.json Defines focused test-file configuration.
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.test.tsx Stabilizes virtualized-row assertions.
common/changes/@itwin/manage-versions-react/omar-manage-versions-eslint-fix_2026-09-02-19-32.json Records the non-release change.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/modules/manage-versions/tsconfig.test.json Outdated
@arome arome changed the title 🐛 Fix manage-versions ESLint config and flaky test Fix manage-versions ESLint config and flaky test Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants