Migrate org scheduler config to jobs#41
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesScheduler config migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 460a2e9fc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "13:30" | ||
| run: | ||
| mode: maintenance | ||
| lateStartGuard: false |
There was a problem hiding this comment.
Preserve the late-start guard for the 01:30 run
With both 01:30 and 13:30 in the same maintenance job, setting lateStartGuard: false disables the existing run.latestStartHour: 7 protection for the overnight slot as well as the afternoon slot. In contexts where the scheduler catches up after downtime or a delayed start after 07:00, the old 01:30 run can now start during the day instead of being skipped; split the times into separate jobs or keep the guard enabled for the overnight job only.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 446bed4: the guarded run is now maintenance with lateStartGuard: true, and the later run is a separate maintenance-followup job with lateStartGuard: false.
460a2e9 to
446bed4
Compare
Summary
.githubscheduler config from fixed scheduler fields toscheduler.jobs.maintenanceand the 13:30 unguarded run asmaintenance-followup.issue-watchjob and raise the scheduled issue limit to 2.Verification
.kaizen/config.ymlbash scripts/check-daily-dogfood-sync-contract.shbash scripts/test-sync-daily-dogfood.shkaizen-loopschemaCloses #40
Summary by CodeRabbit