Skip to content

fix(ci): drop unmatched **/*.mdx pathspec from quarterly-doc-audit - #31

Merged
acamarata merged 1 commit into
mainfrom
fix/quarterly-doc-audit-mdx-pathspec-v2
Aug 16, 2026
Merged

acamarata merged 1 commit into
mainfrom
fix/quarterly-doc-audit-mdx-pathspec-v2

Conversation

@acamarata

Copy link
Copy Markdown
Contributor

Summary

  • Quarterly doc audit was failing on current main HEAD (run 31956740627, head_sha d999eda) — this is a NEW, unrelated bug, not a residual of the CLI-tarball extraction fix (fix(ci): correct nself release tarball extraction in quarterly-doc-audit #29), which is already correctly in place with --strip-components=1.
  • Root cause: peter-evans/create-pull-request's add-paths list included **/*.mdx, but this repo has zero .mdx files. git add's multi-pathspec matching is atomic — one unmatched pathspec element aborts the entire git add, so none of the 44 legitimately modified .md wiki files got staged either. The commit step then failed with "no changes added to commit".
  • Fix: drop **/*.mdx from add-paths since this repo is pure Markdown (confirmed via find . -iname '*.mdx' → 0 results).

Test plan

  • Reproduced the atomic-pathspec-abort behavior locally with a scratch git repo (unmatched pathspec element in a multi-arg git add aborts the whole command, matching the exact CI log).
  • Confirmed via gh run view 31956740627 --log-failed that the doc-audit tool itself ran fine and produced real (expected) findings — this is a workflow bug, not doc drift to fix in content.
  • Watch Quarterly doc audit run green on main HEAD after merge.

…d-paths

peter-evans/create-pull-request's git add treats multiple pathspec
arguments atomically: since this repo has zero .mdx files, the
**/*.mdx pathspec always fails with 'pathspec did not match any
files', which aborts the whole git add — so none of the 44 legitimately
modified .md wiki files get staged either, and the commit step then
fails with 'no changes added to commit'.

Confirmed via gh run view --log-failed on run 31956740627 (head_sha
d999eda, current main HEAD) and reproduced locally: an unmatched
pathspec element in a multi-pathspec git add aborts the entire
command. This is unrelated to the prior --strip-components=1 CLI
tarball fix (#29), which is already correctly in place.

find . -iname '*.mdx' confirms this repo has no mdx files, so drop
the pattern entirely rather than working around it.
@acamarata
acamarata merged commit a858d04 into main Aug 16, 2026
34 checks passed
acamarata added a commit to nself-org/ntask that referenced this pull request Aug 16, 2026
…d-paths (#89)

Consistency fix alongside cli/plugins (same underlying bug as
nself-org/plugins#31): this repo has zero .mdx files, so
git add -- **/*.md **/*.mdx ... would fatal on the unmatched **/*.mdx
pathspec and abort the whole add the moment the audit actually finds
and stages real .md changes. Currently latent — ntask's last audit
run on current main HEAD was clean (workflow_dispatch run 31957713422,
head_sha 403e72f, conclusion success) — but the bug is real and would
break the next run that finds doc drift.
acamarata added a commit that referenced this pull request Aug 16, 2026
… add-paths (#33)

The real, complete root cause of the Open-auto-fix-PR failures (after the
mdx-pathspec fix in #31): .claude/ is gitignored repo-wide (org-standard
per GCI -- '.claude/ standard: gitignored AI memory', confirmed via
'grep claude .gitignore' hitting 5 separate ignore lines here). git add's
multi-pathspec matching is atomic and does NOT count gitignored files as
a match even when the file genuinely exists on disk with fresh content --
reproduced locally:

  echo '.claude/' > .gitignore; git add .gitignore; git commit -qm init
  mkdir -p .claude/qa/findings; echo '{}' > .claude/qa/findings/test.json
  git add -- '.claude/qa/findings/*.json'
  # fatal: pathspec '.claude/qa/findings/*.json' did not match any files

So '.claude/qa/findings/*.json' in add-paths was ALWAYS going to fail
git add the moment any other add-paths pattern (**/*.md) also had real
changes to stage -- confirmed live: run 31958209014 on commit 5b79fb2
(the #31/#32 fix) failed with exactly this pathspec, once the mdx bug
was out of the way and 44 real .md changes needed staging.

This isn't a real loss: the JSON report is already preserved via the
'Upload JSON report' actions/upload-artifact step (180-day retention)
and fed into the PR body directly via body-path, independent of git
staging. Dropping it from add-paths means it simply never gets committed
into the repo -- which is correct, since .claude/ is supposed to stay
untracked everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant