Repository navigation
docs(zh): approvals spells plugin-owned view and tab names from the owner zh-CN pack - #1971
Conversation
…wner's zh-CN pack (#1552) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
CI blocker:
The fix touches only that test, and adds no guard:
The file is outside the claimed surface, so the fix waits for the maintainer to widen scope before it is pushed here. This is not a flake, so no re-run. Generated by Claude Code |
…anguage (#1552) Ruling C spells plugin-owned view names from the owner's zh-CN pack, so the zh pages no longer carry the English view labels or the English-plus-gloss form. The section check now takes each face's labels: en from the schema, zh-Hans from the plugin's zh-CN block (read off the decoded bundle, as docs-search-navigation-views does), zh-Hant by character conversion. The zh quotedFromConsole fixtures drop the retired English 'My Pending' and, on zh-Hant, the simplified 我发起的 the page no longer spells. No guard added. Maintainer scope: 「1971 可以改测试,繁体用繁体」. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8U3asekbiC7yWoEPWR4Dg
|
ACCEPT — #1552: approvals spells plugin-owned view and tab names from the owner's zh-CN pack. The CI blocker above is fixed in
The zh Every check is green on Marking ready and enabling auto-merge. #1552 closes on merge. Generated by Claude Code |
Fixes #1552
Applies the option C ruling (comment 5566182270). On a Chinese docs page a view name is spelled with the zh-CN value from the pack of the package that owns the object. For
sys_approval_requestthat pack is plugin-approvals' own bundle. The English-plus-parenthesis gloss form is dropped. Onlycontent/docs/revenue/approvals.zh-Hans.mdxand.zh-Hant.mdxchange, plus one empty-frontmatter changeset. Nothing ships.Measured sources (installed pin
@objectstack/*17.5.0)node_modules/@objectstack/plugin-approvals/dist/index.mjsdeclaressys_approval_request.listViewswith four entries. Itssrc/translations/zh-CN.objects.generated.tsblock (the one registered under"zh-CN") gives the labels below.zhCNGeneratedSourceHashescarries no view key, so none of them falls back to English.node_modules/@objectstack/console/dist/assets/i18n-locale-zh-*.jsrenders them asapprovalsInbox.tabMyPending/tabSubmitted/tabAll= 待我审批 / 我发起的 / 全部, and the en locale has My Pending / Submitted by me / All. The owning package ships a zh string, so the same principle applies to them.View-by-view mapping
my_pending)submitted_by_me)completed)all_requests)tabMyPending)tabSubmitted)tabAll)zh-Hant uses the Traditional-script form of the same string, which is the conversion the page and the AGENTS.md zh-Hant rule already apply (审 to 審, 发 to 發). No word is swapped. The zh-Hant tab table's lead-in no longer says Simplified strings are listed alongside, because the rows no longer carry them.
Stale-row decision: none removed
The card counted five view names against the plugin's four. Measured on the pin, the object-views table on the current page has four rows: My Pending, I Submitted, Completed and All. They map one-to-one to
my_pending,submitted_by_me,completedandall_requests, and each row's description matches the view's filter. The premise thatI Submittedis not in the bundle does not hold.I Submittedis the Englishlabelofsubmitted_by_me, and the key name is probably where that reading came from. The fifth name,Submitted by me, is the approval centre's tabtabSubmitted, which lives in the tabs table. It is not a view, so no row is stale and none was merged. The collision table still holds on both faces: 待我审批 and 全部 appear verbatim on both sides, and 我提交的 / 我发起的 differ by one word.Prose
The "why the names changed" paragraph now names the views as 待我审批 / 我提交的 / 已完成. Its point is that the English tab differs from the phantom Submitted by Me only in capitalisation. To keep that point, it now says the 我发起的 tab is called Submitted by me in the English UI. The three phantom names and the Inbox, Approval Requests and Action History denials are unchanged.
Known red:
test/docs-revenue-approvals-navigation.test.ts(out of this card's file surface, not edited)pnpm verifyat 7cd0b0e: validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens and build all pass. The test step reportsTest Files 1 failed | 172 passed (173)andTests 4 failed | 3721 passed | 1 skipped. All four failures are in this file, two per zh face.quotedFromConsole(L243-246 and L279-282) require the EnglishMy Pending, plus我发起的in Simplified script on zh-Hant.REQUEST_VIEWSon every face.Both pins encode the gloss form the ruling retired. The fix needs maintainer scope and is left to the seat.
Not changed (outside the ruled rows)
sys_approval_actionviews Recent / By Actor / All. These are plugin-owned views of the same class, but they sit outside the rows the ruling names.Generated by Claude Code