Fix move (M/drag) not working after toggling Data panel with node selected (#9582)#11899
Open
FaisalMisbah23 wants to merge 1 commit intoopenstreetmap:developfrom
Open
Conversation
FaisalMisbah23
force-pushed
the
fix/9582-move-node-after-data-panel-toggle
branch
from
8af58eb to
0253c94
Compare
FaisalMisbah23
force-pushed
the
fix/9582-move-node-after-data-panel-toggle
branch
from
0253c94 to
fe1a876
Compare
Author
|
Friendly ping, any thoughts on this data panel focus/move fix? I've rebased onto the current development, tested it locally, and can provide more details/screenshots if helpful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9582
Problem: After toggling a layer or map-feature checkbox in the Data panel (e.g. enabling "Paths") with a node selected, moving the node via M or drag did not work—the map panned instead. Workaround was to click outside the checkbox so focus left the input.
Cause: Focus stayed on the checkbox (input element), so keyboard shortcuts were not handled and interaction was wrong.
Fix: Blur the active element after toggling in both Map Features (
map_features.js) and Data layers (data_layers.js) so focus leaves the panel and M/drag work without an extra click.