Skip to content

Fix move (M/drag) not working after toggling Data panel with node selected (#9582) #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FaisalMisbah23 wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −0
Open

Fix move (M/drag) not working after toggling Data panel with node selected (#9582) #11899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
* Add `railway=crossing` tag when connecting two railways using the validation fix ([#9226], thanks [@paulklie])
#### :bug: Bugfixes
* Fix typo: `parking:left:capacity` duplicated in osmSummableTags, missing `parking:right:capacity` ([#11819], thanks [@JaiswalShivang])
* Fix move (M / drag) not working after toggling Data panel layer or Map Features checkbox with a node selected; blur focus from checkbox so shortcuts work ([#9582])
* Fix some gpx/geojson properties not visible, such as numbers or complex data structures ([#11636], thanks [@k-yle])
* Fix error setting custom background ([#11862], thanks [@Kayd-06])
* Fix crash when commenting/closing notes when the note is closed by another mapper in the meantime ([#8464])
Expand Down Expand Up @@ -130,6 +131,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
[#10935]: https://github.com/openstreetmap/iD/issues/10935
[#10999]: https://github.com/openstreetmap/iD/pull/10999
[#11327]: https://github.com/openstreetmap/iD/pull/11327
[#9582]: https://github.com/openstreetmap/iD/issues/9582
[#11522]: https://github.com/openstreetmap/iD/issues/11522
[#11533]: https://github.com/openstreetmap/iD/pull/11533
[#11589]: https://github.com/openstreetmap/iD/pull/11589
Expand Down
4 changes: 4 additions & 0 deletions modules/ui/sections/data_layers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ export function uiSectionDataLayers(context) {

function toggleLayer(which) {
setLayer(which, !showsLayer(which));
// Release focus from the checkbox so keyboard shortcuts (e.g. M for move) work (fixes #9582)
if (document.activeElement && /^(INPUT|SELECT|TEXTAREA)$/.test(document.activeElement.tagName)) {
document.activeElement.blur();
}
}

function drawOsmItems(selection) {
Expand Down
4 changes: 4 additions & 0 deletions modules/ui/sections/map_features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ export function uiSectionMapFeatures(context) {

function clickFeature(d3_event, d) {
context.features().toggle(d);
// Release focus from the checkbox so keyboard shortcuts (e.g. M for move) work (fixes #9582)
if (document.activeElement && /^(INPUT|SELECT|TEXTAREA)$/.test(document.activeElement.tagName)) {
document.activeElement.blur();
}
}

function showsLayer(id) {
Expand Down