feat(broker): support AgentKit tool continuations - #3
Merged
Merged
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a7223ebc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted AgentKit agents can now continue multi-step workflows after Orka executes each requested tool. Configure
ORKA_FOUNDRY_BROKER_AGENTKIT_CONTINUATION_PROOFwith the hosted agent's shared proof. After validating ownership, leases, and response/call IDs, the broker normalizes MCP success/error results and attaches the proof to tool-result continuations.Caller-supplied proof fields and headers are rejected. The proof stays outside the ACP child, ledger, and logs. Conflicting case-folded MCP error flags are also rejected before projection. Bounded failure diagnostics expose only a failure stage, hashed owner, invocation sequence, allowlisted error code, and numeric HTTP status; response bodies and provider messages remain excluded.
Validation:
make verify, focused race-detector tests, and production image builds passed.Cancelled / TaskTimeout.The shared proof authenticates the continuation route; it is not a signed execution receipt. Approval-required tools remain unsupported. Lost acknowledgements and unresolved remote ownership still fail closed; these changes do not authorize inference replay or forced cleanup.
Companion AgentKit change: sozercan/agentkit#25