Skip to content

feat(buck2): move bounded Weaver checks - #1302

Merged
schickling merged 1 commit into
mainfrom
schickling-assistant/2026-09-17-s11-weaver
Sep 23, 2026
Merged

schickling merged 1 commit into
mainfrom
schickling-assistant/2026-09-17-s11-weaver

Conversation

@schickling-assistant

@schickling-assistant schickling-assistant commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Problem

Weaver validation still mixed bounded semantic checks with broader setup and publication work, obscuring which checks belong in the fast aggregate path.

Goal

Move the bounded Weaver checks onto the standalone Buck-root task graph introduced by #1301 while keeping live and unbounded checks explicit.

Decisions

Verification

  • GitHub auto-rebased this PR onto merged feat(buck2): add standalone root and aggregate gates #1301 squash c25fb3296b5ed4164123e5eee4e58cee628f5c62; its one own commit is now 51fb3865614dd9dc8238f4379b60e050ce79da7b.
  • The pinned generated workflow remains the source of truth; required-check run 35802858174 completed successfully.
  • The final stack passes both scoped Buck static checks (lint:check:oxlint and lint:check:format) from a local-disk checkout.

Complexity

  • Ledger: 359 lines added, 237 removed, net +122, measured by buck2-ledger.ts at 51fb3865614dd9dc8238f4379b60e050ce79da7b.

Concerns

Friction & bottlenecks

Follow-ups

  • Keep live Weaver publication authority separate from bounded pull-request checks.

References

Posted on behalf of @schickling
field value
agent_identity dev3.direct.omp.t3mkm4sd
session unknown
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.1.14
agent_runtime OMP 18.1.14
tooling_profile dotfiles@5d1e05f

@schickling-assistant schickling-assistant changed the title schickling assistant/2026 09 17 s11 weaver feat(buck2): move bounded Weaver checks Sep 18, 2026
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from f49989c to bc88155 Compare September 21, 2026 22:29
@schickling-assistant
schickling-assistant added this pull request to stack #1332 September 21, 2026 22:32
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from bc88155 to 406b049 Compare September 22, 2026 11:41
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from 406b049 to a793163 Compare September 22, 2026 12:13
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from a793163 to 693d1d9 Compare September 22, 2026 12:51
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from 693d1d9 to 2ec1b44 Compare September 22, 2026 14:28
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from 2ec1b44 to 7a50a65 Compare September 22, 2026 15:54
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from 7a50a65 to 2902297 Compare September 22, 2026 17:33
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch 5 times, most recently from 48a0225 to 9ebc57a Compare September 22, 2026 23:34
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from 9ebc57a to f31ce2e Compare September 23, 2026 00:01
@schickling-assistant
schickling-assistant marked this pull request as ready for review September 23, 2026 00:36
@github-actions
github-actions Bot requested a review from schickling September 23, 2026 00:36
Base automatically changed from schickling-assistant/2026-09-15-quick-aggregate to main September 23, 2026 00:37
agent-identity: dev3.direct.omp.86q5uf7k
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.2.0
agent-runtime: OMP 18.2.0
agent-model: openai-codex/gpt-5.6-sol
tooling-profile: dotfiles@14c708d
@schickling
schickling force-pushed the schickling-assistant/2026-09-17-s11-weaver branch from f31ce2e to 51fb386 Compare September 23, 2026 00:37
@schickling-assistant
schickling-assistant marked this pull request as draft September 23, 2026 00:38
@schickling-assistant
schickling-assistant marked this pull request as ready for review September 23, 2026 00:40
@schickling-assistant

Copy link
Copy Markdown
Collaborator Author

@codex review

Posted on behalf of @schickling
field value
agent_identity dev3.direct.omp.fkazdy6v
session unknown
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.2.6
agent_runtime OMP 18.2.6
agent_model openai-codex/gpt-5.6-sol
worktree 2026-09-22-fix-checks/2026-09-22-fix-checks
tooling_profile dotfiles@965ef7e-dirty

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-23T03:56:18.908454Z 51fb386 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 51fb386561

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@schickling
schickling merged commit 2e0311d into main Sep 23, 2026
28 checks passed
@schickling
schickling deleted the schickling-assistant/2026-09-17-s11-weaver branch September 23, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants