feat(buck2): move bounded Weaver checks - #1302
Merged
Merged
Conversation
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 21, 2026 22:29
f49989c to
bc88155
Compare
schickling-assistant
added this pull request to stack #1332
September 21, 2026 22:32
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 11:41
bc88155 to
406b049
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 12:13
406b049 to
a793163
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 12:51
a793163 to
693d1d9
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 14:28
693d1d9 to
2ec1b44
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 15:54
2ec1b44 to
7a50a65
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 22, 2026 17:33
7a50a65 to
2902297
Compare
This was referenced Sep 22, 2026
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
5 times, most recently
from
September 22, 2026 23:34
48a0225 to
9ebc57a
Compare
schickling-assistant
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 23, 2026 00:01
9ebc57a to
f31ce2e
Compare
schickling-assistant
marked this pull request as ready for review
September 23, 2026 00:36
Base automatically changed from
schickling-assistant/2026-09-15-quick-aggregate
to
main
September 23, 2026 00:37
agent-identity: dev3.direct.omp.86q5uf7k agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.0 agent-runtime: OMP 18.2.0 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@14c708d
schickling
force-pushed
the
schickling-assistant/2026-09-17-s11-weaver
branch
from
September 23, 2026 00:37
f31ce2e to
51fb386
Compare
schickling-assistant
marked this pull request as draft
September 23, 2026 00:38
schickling-assistant
marked this pull request as ready for review
September 23, 2026 00:40
Collaborator
Author
|
@codex review Posted on behalf of @schickling
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Weaver validation still mixed bounded semantic checks with broader setup and publication work, obscuring which checks belong in the fast aggregate path.
Goal
Move the bounded Weaver checks onto the standalone Buck-root task graph introduced by #1301 while keeping live and unbounded checks explicit.
Decisions
Verification
c25fb3296b5ed4164123e5eee4e58cee628f5c62; its one own commit is now51fb3865614dd9dc8238f4379b60e050ce79da7b.lint:check:oxlintandlint:check:format) from a local-disk checkout.Complexity
buck2-ledger.tsat51fb3865614dd9dc8238f4379b60e050ce79da7b.Concerns
Friction & bottlenecks
/srv/bulkBuck timings are invalid under dotfiles#2955; the feat(buck2): add standalone root and aggregate gates #1301 local-disk control run proves the inherited standalone root and pinned Buck path.Follow-ups
References
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile