Skip to content

refactor(buck2): make repository checks standalone - #1323

Draft
schickling-assistant wants to merge 2 commits into
schickling-assistant/2026-09-17-s11-weaverfrom
schickling-assistant/2026-09-19-l3-cut1
Draft

schickling-assistant wants to merge 2 commits into
schickling-assistant/2026-09-17-s11-weaverfrom
schickling-assistant/2026-09-19-l3-cut1

Conversation

@schickling-assistant

@schickling-assistant schickling-assistant commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Problem

Repository aggregate checks still carried composition-era graph edges after effect-utils adopted a tracked standalone Buck root.

Goal

Make the repository check surface standalone, remove mr prerequisites from the check graph, and refresh the recorded graph evidence without changing the remaining explicit cross-repository composition contract.

Decisions

  • Remove mr:setup, mr:check, mr:lock-sync-check, and mr:source-policy-check from the standalone check graph.
  • Keep canonical effect_utils// platform and target labels.
  • Preserve standalone bootstrap wording and the bootstrap → Genie freshness dependency inherited from feat(buck2): add standalone root and aggregate gates #1301.
  • Treat cross-shape action-key comparison as migration evidence, not a permanent parity requirement.
  • Keep exactly two own commits: implementation followed by refreshed evidence.

Verification

  • Standalone task-graph proof: all 205 assertions passed.
  • The proof confirms the removed mr tasks are absent and check:all has no mr:apply dependency.
  • Required GitHub checks on the latest revision are the merge gate.

Complexity

  • Ledger: 43 lines added, 23 removed, net +20, measured by buck2-ledger.ts at 90a99162aeaa0178339918a1a95b97828dfb57ba.

Concerns

  • This PR removes effect-utils check-graph composition edges only. It does not delete the shared mr machinery still needed by downstream repositories.

Friction & bottlenecks

Follow-ups

  • Delete the paused composed shape at L3 cut 2 after remaining downstream edges move.

References

Posted on behalf of @schickling
field value
agent_identity dev3.direct.omp.t3mkm4sd
session unknown
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.1.14
agent_runtime OMP 18.1.14
tooling_profile dotfiles@5d1e05f

@schickling-assistant
schickling-assistant added this pull request to stack #1312 September 19, 2026 23:29
@schickling-assistant schickling-assistant changed the title schickling assistant/2026 09 19 l3 cut1 refactor(buck2): make repository checks standalone Sep 19, 2026
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-19-l3-cut1 branch from ddaba77 to 15d85c6 Compare September 21, 2026 22:29
@schickling-assistant
schickling-assistant removed this pull request from stack #1312 September 21, 2026 22:31
@schickling-assistant
schickling-assistant changed the base branch from schickling-assistant/2026-09-19-s9b-react-products to schickling-assistant/2026-09-17-s11-weaver September 21, 2026 22:32
@schickling-assistant
schickling-assistant added this pull request to stack #1332 September 21, 2026 22:32
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-19-l3-cut1 branch 2 times, most recently from b9924cc to 6eb7140 Compare September 22, 2026 12:12
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-19-l3-cut1 branch from 6eb7140 to 21a0602 Compare September 22, 2026 12:51
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-19-l3-cut1 branch from 21a0602 to 015d2ac Compare September 22, 2026 14:28
@schickling-assistant
schickling-assistant force-pushed the schickling-assistant/2026-09-19-l3-cut1 branch from 015d2ac to 4b9a73b Compare September 22, 2026 15:55
agent-identity: dev3.direct.omp.8uhgh9vt
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.2.6
agent-runtime: OMP 18.2.6
agent-model: openai-codex/gpt-5.6-sol
tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.8uhgh9vt
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.2.6
agent-runtime: OMP 18.2.6
agent-model: openai-codex/gpt-5.6-sol
tooling-profile: dotfiles@965ef7e-dirty

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant