Draft
Conversation
Contributor
Author
|
There's a lot of boilerplate I had to add, such as UUID, assertions and validation methods. All that should probably be extracted into its own PR and merged into main before this one, where only WebAudio stuff should be changed (plus all the test cases). |
rdw-software
force-pushed
the
54-webaudio-api
branch
2 times, most recently
from
5acf01e to
86984a7
Compare
This was referenced Nov 17, 2021
rdw-software
force-pushed
the
54-webaudio-api
branch
from
86984a7 to
aaabb4a
Compare
rdw-software
force-pushed
the
54-webaudio-api
branch
2 times, most recently
from
f3949d0 to
6ca004e
Compare
rdw-software
force-pushed
the
54-webaudio-api
branch
from
5c57ecb to
19c9912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Not finished by far. There's a lot to port over and some new things to add/other stuff to rework.