fix(host-agent): reject oversized JSON bodies - #2965
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_BODYlimit with HTTP 413Why this matters
Every host-agent JSON mutation endpoint calls
read_json_body()orread_optional_json_body(). Both readers previously consumedmin(Content-Length, MAX_BODY)and attempted to parse that prefix. A caller declaring an oversized body could therefore get inconsistent results (including acceptance when the available prefix happened to be valid JSON), while unread bytes remained on a persistent HTTP connection and could corrupt framing for the next request.Root cause:
MAX_BODYwas used as a truncation length instead of an admission limit. The invariant is that a JSON request is either read exactly as declared within the configured bound, or rejected before consumption with the connection closed.This is runtime correctness at the authenticated host-agent boundary; it is not presented as an unauthenticated remote security issue.
Overlap check
Searched open and closed PR titles for
host-agent body,Content-Length host agent,MAX_BODY JSON, andrequest body too large. No semantic match exists. I also inspected every open PR touchingods/bin/ods-host-agent.py; current work there concerns OpenCode lifecycle, GPU/runtime planning, rootless reachability, PID writes, and remote-provider state transactions, not HTTP body framing.Merged file history was also checked; the nearest body-size work is the endpoint-specific
.envupdate cap, which does not protect the shared JSON readers.Regression test
The parameterized boundary test calls both shared readers with
Content-Length = MAX_BODY + 1and a syntactically valid prefix. It asserts 413,Connection: closestate, and that zero payload bytes were consumed.Pre-fix evidence: both cases returned
{}. Post-fix validation:pytest tests/test_host_agent.py -q— 259 passed, 4 skippedpython -m py_compile ../../../bin/ods-host-agent.py tests/test_host_agent.py— passedgit diff --check— passedTradeoffs and rollback
Oversized requests now require a new connection after the 413 response; this is intentional because the body is not drained. Valid requests at or below
MAX_BODYare unchanged. Revert commit0fdb3dd1to roll back; no state or schema migration is involved.Generated with Codex
Batch compatibility
Validated as an independent ten-PR batch from upstream
main6ff9b4fc5190099705043acaab7e9b6ad9c8b8f1. The final PR heads merged without conflicts in this order: #2964 -> #2965 -> #2967 -> #2969 -> #2970 -> #2971 -> #2972 -> #2973 -> #2974 -> #2975. The resulting local synthetic merge head is4ae60eadad9696a9accb735aad71af87d2be802d.Combined validation on that exact tree:
git diff --check: passed.The scopes are behaviorally independent. The stated order is the tested rollback/merge sequence for shared-file changes; each PR remains individually useful and revertible.