fix(ape): count each policy decision once - #2974
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
APE's
/metricstotalsummed every exposed counter. Several counters are additive diagnostics for the same/verifydecision: a circuit-breaker denial also incrementsdenied, a window denial also incrementsdenied, and an approved retry increments bothallowedandgrants_consumed. Approval actions were included too. Dashboards and operators therefore saw inflated decision totals.Root cause: the aggregate did not distinguish mutually exclusive primary decision outcomes from lifecycle/diagnostic counters.
Behavioral invariant: every
/verifyrequest contributes exactly one tototal; detailed additive counters remain available unchanged.Overlap check
Searched open and closed upstream PRs for APE metrics/decision-total/counter/double-counting terms and inspected PRs touching
ods/extensions/services/ape/main.py. Current APE PRs cover classification and allowlists; older governance/state work introduced the additive counters but no PR corrects their aggregate. This scope is independent.What changed
totalfrom only those mutually exclusive outcomes.decisionsobject.Validation
/verifycalls producedtotal: 7because approval/grant counters were counted again.pytest tests/test_main.py::test_metrics_total_counts_each_verify_decision_once -q— 1 passed.pytest tests -q— 45 passed.python -m py_compile main.py tests/test_main.py— passed.git diff --check— passed.Compatibility and rollback
The detailed counters and their meanings do not change; only the previously inflated aggregate is corrected. Consumers relying on the incorrect total will observe a decrease that now matches actual verification decisions. No persisted state or schema changes; rollback is one commit.
Batch compatibility
Validated as an independent ten-PR batch from upstream
main6ff9b4fc5190099705043acaab7e9b6ad9c8b8f1. The final PR heads merged without conflicts in this order: #2964 -> #2965 -> #2967 -> #2969 -> #2970 -> #2971 -> #2972 -> #2973 -> #2974 -> #2975. The resulting local synthetic merge head is4ae60eadad9696a9accb735aad71af87d2be802d.Combined validation on that exact tree:
git diff --check: passed.The scopes are behaviorally independent. The stated order is the tested rollback/merge sequence for shared-file changes; each PR remains individually useful and revertible.