fix(privacy-shield): preserve HTTP query strings - #2972
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
Privacy Shield's authenticated HTTP catch-all rebuilt the upstream URL from only the route path. Query parameters were silently discarded, so pagination, filters, cursors, feature flags, and provider-specific options could change meaning between the client request and the model/API upstream.
Root cause:
target_urlomitted the ASGIquery_stringeven though the WebSocket lane already preserves query parameters.Behavioral invariant: the exact raw query bytes received at the HTTP boundary are attached to the same upstream path without decoding/re-encoding them.
Overlap check
Searched open and closed upstream PRs for Privacy Shield query-string/query-parameter/proxy-URL/passthrough terms and inspected PRs changing
ods/extensions/services/privacy-shield/proxy.py. Current work addresses an await bug and error-information leakage; no PR preserves HTTP query strings. The WebSocket query handling is existing behavior and is not modified.What changed
httpx.URL.Validation
/v1/models;?limit=5&cursor=a%2Fb&tag=x+ywas missing.pytest tests/test_streaming_proxy.py::TestQueryPassthrough -q— 1 passed.pytest tests -q— 53 passed.python -m py_compile proxy.py tests/test_streaming_proxy.py— passed.git diff --check— passed.Platform and rollback
This is shared Python behavior across Linux, macOS, and Windows/WSL containers; no platform-specific path changes. The request body, PII scrubbing, headers, and response streaming are untouched. Rollback is one commit with no state migration.
Batch compatibility
Validated as an independent ten-PR batch from upstream
main6ff9b4fc5190099705043acaab7e9b6ad9c8b8f1. The final PR heads merged without conflicts in this order: #2964 -> #2965 -> #2967 -> #2969 -> #2970 -> #2971 -> #2972 -> #2973 -> #2974 -> #2975. The resulting local synthetic merge head is4ae60eadad9696a9accb735aad71af87d2be802d.Combined validation on that exact tree:
git diff --check: passed.The scopes are behaviorally independent. The stated order is the tested rollback/merge sequence for shared-file changes; each PR remains individually useful and revertible.