fix(setup): accept standard 64-hex Wi-Fi PSKs - #2967
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this matters
NetworkManager's shipped contract accepts either an ASCII WPA passphrase or a 64-character hexadecimal pre-shared key. ODS capped the password field at 63 characters in both dashboard-api and host-agent, so a Linux operator whose access point is configured with a raw standards-compliant PSK could never connect through first-run setup.
Root cause: ODS modeled only the passphrase form of
802-11-wireless-security.psk. The invariant is parity between browser validation and host-agent validation: 64 characters are accepted only when every character is hexadecimal, and the exact value reachesnmcliunchanged.NetworkManager contract: https://www.networkmanager.dev/docs/api/latest/nm-settings-nmcli.html
Overlap check
Searched open and closed PR titles for
wifi password,WiFi PSK,64 hex PSK, andNetworkManager password. No matching PR exists. I inspected all open PRs touchingrouters/setup.pyandods-host-agent.py; setup PRs #2816/#2572/#2437/#2323 concern atomic or malformed persisted state, while current host-agent PRs concern OpenCode, GPU/runtime, rootless connectivity, and lifecycle state. None changes Wi-Fi credential validation.Regression tests
Two public handoff points are covered:
POST /api/setup/wifi-connectaccepts a 64-hex PSK and forwards it unchangedAgentHandler._handle_network_wifi_connectaccepts the same request and invokesnmcli device wifi connect ... password <psk>Both tests failed before the implementation (dashboard returned 422; host-agent returned 400). Post-fix validation:
pytest tests/test_network_config.py -q— 18 passedpytest tests/test_host_agent.py -q— 258 passed, 4 skippedgit diff --check— passedPlatform scope, tradeoffs, and rollback
The browser schema is shared, but Wi-Fi mutation remains Linux/NetworkManager-only; macOS and Windows continue to receive the existing unsupported-platform response from host-agent. Non-hex 64-character values remain rejected, avoiding accidental expansion beyond NetworkManager's raw-PSK form. Revert commit
bab15063to roll back; no state migration is required.Generated with Codex
Batch compatibility
Validated as an independent ten-PR batch from upstream
main6ff9b4fc5190099705043acaab7e9b6ad9c8b8f1. The final PR heads merged without conflicts in this order: #2964 -> #2965 -> #2967 -> #2969 -> #2970 -> #2971 -> #2972 -> #2973 -> #2974 -> #2975. The resulting local synthetic merge head is4ae60eadad9696a9accb735aad71af87d2be802d.Combined validation on that exact tree:
git diff --check: passed.The scopes are behaviorally independent. The stated order is the tested rollback/merge sequence for shared-file changes; each PR remains individually useful and revertible.